Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring transformers/spectral_based #224

Closed
fkiraly opened this issue Feb 1, 2020 · 1 comment
Closed

Refactoring transformers/spectral_based #224

fkiraly opened this issue Feb 1, 2020 · 1 comment
Assignees
@mloning
Labels
good first issue Good for newcomers implementing algorithms Implementing algorithms, estimators, objects native to sktime

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Feb 1, 2020 •
edited by mloning
Loading

During an informal code review, I noticed that transformers/spectral_based.py use a custom mechanism to do the same as applying the compositor RowWiseTransformer from sktime.transformers.compose to single-series-transformers would do.

Should this be re-factored?

I believe @jsellier wrote the original version in an early stag of the project where RowWiseTransformer may not yet have existed.
@mloning mloning added good first issue Good for newcomers implementing algorithms Implementing algorithms, estimators, objects native to sktime labels Feb 3, 2020
@mloning mloning changed the title transformers in transformers/spectral_based.py use custom RowWise transformer applicate Refactoring transformers/spectral_based Feb 3, 2020
@mloning
Copy link
Contributor

mloning commented Nov 13, 2020

Close this in favour of #483

@mloning mloning closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mloning mloning

Labels
good first issue Good for newcomers implementing algorithms Implementing algorithms, estimators, objects native to sktime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkiraly @mloning