Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Mismatch between 0.4.1 docs and release #386

Closed
thorbjornwolf opened this issue Aug 26, 2020 · 4 comments
Closed

[DOC] Mismatch between 0.4.1 docs and release #386

thorbjornwolf opened this issue Aug 26, 2020 · 4 comments
Labels
documentation Documentation & tutorials

Comments

@thorbjornwolf
Copy link

Thank you for spending some of your valuable time on open source 馃

Describe the issue linked to the documentation

The documentation for NaiveForecaster includes "drift" and says 0.4.1 in the upper left corner. Link, but not a permalink. The package version 0.4.1 does not support "drift", but fails with ValueError: Unknown strategy: drift; expected one of ('last', 'mean', 'seasonal_last').

I don't see a way to access the docs for older versions.

My hypothesis

I believe that

  1. docs are autobuilt and deployed from master on new changes
  2. master is often ahead of the latest release
  3. package version in master is only updated at release time
  4. Consequently, the hosted docs are ahead of the latest release, while retaining the version number of the latest release. Some confusion may arise 馃榿

So when #383 enriched master with all the good stuff from dev, updated docs were built and deployed under the current version, and no package release was made.

Suggest a potential alternative/fix

I sure don't know what would be the best(tm) way of handling this, but here's a few ideas for starters:

  1. Only build docs when also cutting a release (but this goes against the wish to have updated tutorial notebooks)
  2. Separate tutorial notebooks from the API docs so they can be built independently
  3. Differentiate among doc versions, so one could view either 0.4.1 or master/cutting edge.

Thank you for your attention. Cheers!

@thorbjornwolf thorbjornwolf added the documentation Documentation & tutorials label Aug 26, 2020
@mloning
Copy link
Contributor

mloning commented Aug 26, 2020

Thanks for raising the issue! We actually thought about a few things that could go wrong when we changed the workflow over to master in #360, but this one didn't cross our minds! 馃槃

Differentiating between doc version seems like a good suggestion. I've seen this in other repos, but wouldn't know where to start. Would you be interested in setting that up?

@mloning
Copy link
Contributor

mloning commented Aug 26, 2020

https://readthedocs.org seems like the way to go. @thorbjornwolf if you're interested in setting up readthedocs that would be highly appreciated!

@thorbjornwolf
Copy link
Author

Hi @mloning! I'm afraid I won't find the time anytime soon. It does sound like a very good exercise in a generally applicable open-source skill, though. I wonder if there exist cross-project opensourcers who have experience with this 馃

@mloning
Copy link
Contributor

mloning commented Sep 17, 2020

Fixed by #395

@mloning mloning closed this as completed Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

No branches or pull requests

2 participants