-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Adapter for Uni2TS, MOIRAI #6161
Comments
hm, so it's using I suppose we need to continue the work on the |
Might be helpful or at least this seems to be code that can be shared easily. |
I had a discussion with @benHeid and will start working on this |
I have started working on implementing MOIRAI foundation model in sktime, and will be continuing to work on the
I'm bit concerned about the license being used here, although I don't have deep understanding of open source licenses. Will this implementation still be useful for sktime users with the CC BY-NC license. Also can we load the new format of weights with the HFTransformer class?? |
Adding conversation from discord: fkiraly: hm, when has the license changed? CC NC is not a permissive license, as it may not be used for commercial purposes. So, it would be a limitation, and we should clearly signpost it in the license_type field. Academics can still use it. With the license change, did anything else change? pranavvp16: They changed the license in this commit :https://huggingface.co/Salesforce/moirai-1.0-R-small/commit/10a3e89520d14fbe5769b345190177857966efed, and changes where made to the format of weight files .ckpt - > .safetensors with config.json |
CC NC is not a permissive license, as it may not be used for commercial purposes. So, it would be a limitation, and we should clearly signpost it in a license_type tag or similar. Academics can still use it. With the license change, did anything else change? In We should probably do the same in I would suggest you open an issue where we discuss tagging licenses, and how we want to notify the user. One challenge here is the mix of 1st, 2nd, 3rd party estimators in In-principle, users can build complex pipelines where components have any number of licenses, potentially even mutually contradictory ones... |
Due to different MOIRAI versions varying in weights and licenses, I had a discussion with @benHeid and will be opening a poll/thread under this issue for users and developers of sktime to decide which version of MOIRAI would be good to implement in sktime. Meanwhile I'll start working on implementing |
MOIRAI has different versions on github as well as hugging face with different format of weights and licenses. So we have two versions of github mapping two versions on hugging face. I have saved the old weights at link, but they require the old version of MOIRAI to load the weights in the model. Also if we go with the fork method for installation we need to fork the moirai folder in the uni2ts repository. I would like to know the thoughts of sktime developers and the community, on how and what version of MOIRAI should be implemented in sktime. 🎉 : Old Moirai version which has the This is a poll like setup, and react with the emoji corresponding to the idea you would like to be implemented. Also any thoughts or ideas to the above issue are appreciated. |
Question: why would the new version require a fork? I can see why the old version would require a fork, that's directly before license change. |
MOIRAI i.e uni2ts isn't on PyPi too, So we have to go with one of the methods mentioned by @benHeid in above comment for installation. |
Salesforce is releasing there time series library for transformers training and forecasting. Thus, it might be worth to interface it.
This is also supporting a download of their time series foundation model MOIRAI.
https://github.com/SalesforceAIResearch/uni2ts
The text was updated successfully, but these errors were encountered: