Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShapeletTransformClassifier n_shapelets parameter #898

Closed
MatthewMiddlehurst opened this issue May 21, 2021 · 2 comments
Closed

ShapeletTransformClassifier n_shapelets parameter #898

MatthewMiddlehurst opened this issue May 21, 2021 · 2 comments
Labels
module:classification classification module: time series classification

Comments

@MatthewMiddlehurst
Copy link
Contributor

The ShapeletTransformClassifier currently requires an amount of time in minutes as a parameter to determine how long it should search for shapelets (transform_contract_in_mins). It would be better if there was an alternate parameter giving a set number of shapelets i.e. n_shapelets.

Beyond general usability, mandatory contracting causes some issues for unit testing (STC specifically excludes check_fit_idempotent). This would likely require the implementation of _RandomEnumerationShapeletTransform which is currently a stub in shapelets.py
@MatthewMiddlehurst MatthewMiddlehurst changed the title ShapeletTransformClassifier n_shapelets Parameter ShapeletTransformClassifier n_shapelets parameter May 21, 2021
@TonyBagnall TonyBagnall added the module:classification classification module: time series classification label Jun 20, 2021
@TonyBagnall
Copy link
Contributor

I'm bumping this for myself, it will be rolled into the new general shapelets issue, including unit tests

@MatthewMiddlehurst
Copy link
Contributor Author

Fixed in #1490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:classification classification module: time series classification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TonyBagnall @MatthewMiddlehurst