/
router_update.go
1475 lines (1390 loc) · 48.9 KB
/
router_update.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package client
import (
"context"
"encoding/json"
"fmt"
"log"
"net"
"os"
"os/exec"
"reflect"
"sort"
"strings"
"time"
"github.com/skupperproject/skupper/pkg/utils/configs"
"github.com/google/go-cmp/cmp"
"github.com/skupperproject/skupper/pkg/images"
"github.com/skupperproject/skupper/pkg/version"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/api/rbac/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"
routev1 "github.com/openshift/api/route/v1"
"github.com/skupperproject/skupper/api/types"
"github.com/skupperproject/skupper/pkg/kube"
"github.com/skupperproject/skupper/pkg/qdr"
"github.com/skupperproject/skupper/pkg/site"
"github.com/skupperproject/skupper/pkg/utils"
)
func (cli *VanClient) RouterUpdateVersion(ctx context.Context, hup bool) (bool, error) {
return cli.RouterUpdateVersionInNamespace(ctx, hup, cli.Namespace)
}
func (cli *VanClient) updateStarted(from string, namespace string, ownerrefs []metav1.OwnerReference) error {
cm := &corev1.ConfigMap{
TypeMeta: metav1.TypeMeta{
APIVersion: "v1",
Kind: "ConfigMap",
},
ObjectMeta: metav1.ObjectMeta{
Name: "skupper-update-state",
OwnerReferences: ownerrefs,
},
Data: map[string]string{
"from": from,
},
}
_, err := cli.KubeClient.CoreV1().ConfigMaps(namespace).Create(context.TODO(), cm, metav1.CreateOptions{})
if err != nil {
return err
}
return nil
}
func (cli *VanClient) updateCompleted(namespace string) error {
return cli.KubeClient.CoreV1().ConfigMaps(namespace).Delete(context.TODO(), "skupper-update-state", metav1.DeleteOptions{})
}
func (cli *VanClient) isUpdating(namespace string) (bool, string, error) {
cm, err := cli.KubeClient.CoreV1().ConfigMaps(namespace).Get(context.TODO(), "skupper-update-state", metav1.GetOptions{})
if errors.IsNotFound(err) {
return false, "", nil
} else if err != nil {
return false, "", err
}
return true, cm.Data["from"], nil
}
func (cli *VanClient) RouterUpdateVersionInNamespace(ctx context.Context, hup bool, namespace string) (bool, error) {
// Validate if router config file needs to be renamed
renamedSkRouter, err := cli.renameRouterConfigFile(namespace)
if err != nil {
return false, err
}
configmap, err := cli.KubeClient.CoreV1().ConfigMaps(namespace).Get(context.TODO(), types.TransportConfigMapName, metav1.GetOptions{})
if err != nil {
return false, err
}
config, err := qdr.GetRouterConfigFromConfigMap(configmap)
if err != nil {
return false, err
}
site := config.GetSiteMetadata()
// compare to version of library running
updateSite := false
if utils.LessRecentThanVersion(version.Version, site.Version) {
// site is newer than client library, cannot update
return false, fmt.Errorf("Site (%s) is newer than library (%s); cannot update", site.Version, version.Version)
}
renameFor050 := false
addClaimsSupport := false
addMultiportServices := false
addClusterPolicy := false
updateRouterPolicyRule := false
addCertsSharedVolume := false
substituteFlowCollector := false
addPrometheusServer := false
moveClaims := false
updateRole := false
inprogress, originalVersion, err := cli.isUpdating(namespace)
if err != nil {
return false, err
}
if inprogress {
renameFor050 = utils.LessRecentThanVersion(originalVersion, "0.5.0")
addClaimsSupport = utils.LessRecentThanVersion(originalVersion, "0.7.0")
addMultiportServices = utils.LessRecentThanVersion(originalVersion, "0.8.0")
addClusterPolicy = utils.LessRecentThanVersion(originalVersion, "0.9.0")
updateRouterPolicyRule = utils.LessRecentThanVersion(originalVersion, "0.9.0")
addCertsSharedVolume = utils.LessRecentThanVersion(originalVersion, "0.9.0")
substituteFlowCollector = utils.LessRecentThanVersion(originalVersion, "1.3.0")
addPrometheusServer = utils.LessRecentThanVersion(originalVersion, "1.4.0")
if utils.LessRecentThanVersion(originalVersion, "1.5.0") {
moveClaims = !config.IsEdge()
updateRole = true //config-sync requires extra permission to write skupper-network-status configmap
}
} else {
originalVersion = site.Version
}
if utils.MoreRecentThanVersion(version.Version, site.Version) || (utils.EquivalentVersion(version.Version, site.Version) && version.Version != site.Version) {
if !inprogress {
if utils.LessRecentThanVersion(originalVersion, "0.7.0") {
addClaimsSupport = true
renameFor050 = utils.LessRecentThanVersion(originalVersion, "0.5.0")
}
if utils.LessRecentThanVersion(originalVersion, "0.8.0") {
addMultiportServices = true
}
if utils.LessRecentThanVersion(originalVersion, "0.9.0") {
addClusterPolicy = true
updateRouterPolicyRule = true
addCertsSharedVolume = true
}
if utils.LessRecentThanVersion(originalVersion, "1.3.0") {
substituteFlowCollector = true
}
if utils.LessRecentThanVersion(originalVersion, "1.4.0") {
addPrometheusServer = true
}
if utils.LessRecentThanVersion(originalVersion, "1.5.0") {
moveClaims = !config.IsEdge()
updateRole = true //config-sync requires extra permission to write skupper-network-status configmap
}
err = cli.updateStarted(site.Version, namespace, configmap.ObjectMeta.OwnerReferences)
if err != nil {
return false, err
}
inprogress = true
}
// site is marked as older than library, need to update
updateSite = true
site.Version = version.Version
config.SetSiteMetadata(&site)
_, err = config.UpdateConfigMap(configmap)
if err != nil {
return false, err
}
_, err = cli.KubeClient.CoreV1().ConfigMaps(namespace).Update(context.TODO(), configmap, metav1.UpdateOptions{})
if err != nil {
return false, err
}
}
usingRoutes := false
consoleUsesLoadbalancer := false
routerExposedAsIp := false
if renameFor050 {
// create new resources (as copies of old ones)
// services
_, err = kube.CopyService("skupper-messaging", types.LocalTransportServiceName, map[string]string{}, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
_, err = kube.CopyService("skupper-internal", types.TransportServiceName, map[string]string{}, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
servingCertsAnnotation := map[string]string{
"service.alpha.openshift.io/serving-cert-secret-name": types.ConsoleServerSecret,
}
controllerSvc, err := kube.CopyService("skupper-controller", types.ControllerServiceName, servingCertsAnnotation, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
if controllerSvc != nil {
consoleUsesLoadbalancer = controllerSvc.Spec.Type == corev1.ServiceTypeLoadBalancer
}
// update annotation on skupper-router-console if it exists
routerConsoleService, err := cli.KubeClient.CoreV1().Services(namespace).Get(context.TODO(), types.RouterConsoleServiceName, metav1.GetOptions{})
if err == nil {
if routerConsoleService.ObjectMeta.Annotations == nil {
routerConsoleService.ObjectMeta.Annotations = map[string]string{}
}
routerConsoleService.ObjectMeta.Annotations["service.alpha.openshift.io/serving-cert-secret-name"] = types.OauthRouterConsoleSecret
_, err := cli.KubeClient.CoreV1().Services(namespace).Update(context.TODO(), routerConsoleService, metav1.UpdateOptions{})
if err != nil {
return false, err
}
}
// secrets
// ca's just need to be copied to new secret
err = kube.CopySecret("skupper-ca", types.LocalCaSecret, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
err = kube.CopySecret("skupper-internal-ca", types.SiteCaSecret, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
// credentials need to be regenerated to be valid for new service names
credentials := []types.Credential{}
credentials = append(credentials, types.Credential{
CA: types.LocalCaSecret,
Name: types.LocalServerSecret,
Subject: types.LocalTransportServiceName,
Hosts: []string{types.LocalTransportServiceName, types.QualifiedServiceName(types.LocalTransportServiceName, namespace)},
ConnectJson: false,
})
credentials = append(credentials, types.Credential{
CA: types.LocalCaSecret,
Name: types.LocalClientSecret,
Subject: types.LocalTransportServiceName,
Hosts: []string{},
ConnectJson: true,
})
credentials = append(credentials, types.Credential{
CA: types.ServiceCaSecret,
Name: types.ServiceClientSecret,
Hosts: []string{},
ConnectJson: false,
Post: false,
Simple: true,
})
usingRoutes, err = cli.usingRoutes(namespace)
if usingRoutes {
// no need to regenerate certificate as route names have not changed
err = kube.CopySecret("skupper-internal", types.SiteServerSecret, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
} else {
hosts, err := cli.getTransportHosts(namespace)
if err != nil {
return false, err
}
if len(hosts) > 0 {
ip := net.ParseIP(hosts[0])
if ip != nil {
routerExposedAsIp = true
}
}
subject := types.TransportServiceName
for _, host := range hosts {
if len(host) < 64 {
subject = host
break
}
}
credentials = append(credentials, types.Credential{
CA: types.SiteCaSecret,
Name: types.SiteServerSecret,
Subject: subject,
Hosts: hosts,
ConnectJson: false,
})
}
for _, cred := range credentials {
var owner *metav1.OwnerReference
if len(configmap.ObjectMeta.OwnerReferences) > 0 {
owner = &configmap.ObjectMeta.OwnerReferences[0]
}
kube.NewSecret(cred, owner, namespace, cli.KubeClient)
}
// serviceaccounts
err = kube.CopyServiceAccount("skupper", types.TransportServiceAccountName, map[string]string{}, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
annotationSubstitutions := map[string]string{
"serviceaccounts.openshift.io/oauth-redirectreference.primary": "{\"kind\":\"OAuthRedirectReference\",\"apiVersion\":\"v1\",\"reference\":{\"kind\":\"Route\",\"name\":\"" + types.ConsoleRouteName + "\"}}",
}
err = kube.CopyServiceAccount("skupper-proxy-controller", types.ControllerServiceAccountName, annotationSubstitutions, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
// roles
controllerRole := &rbacv1.Role{
TypeMeta: metav1.TypeMeta{
APIVersion: "rbac.authorization.k8s.io/v1",
Kind: "Role",
},
ObjectMeta: metav1.ObjectMeta{
Name: types.ControllerRoleName,
OwnerReferences: configmap.ObjectMeta.OwnerReferences,
},
Rules: types.ControllerPolicyRule,
}
_, err = kube.CreateRole(namespace, controllerRole, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
err = kube.CopyRole("skupper-view", types.TransportRoleName, namespace, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
// rolebindings
rolebindings := []rbacv1.RoleBinding{
{
TypeMeta: metav1.TypeMeta{
APIVersion: "rbac.authorization.k8s.io/v1",
Kind: "RoleBinding",
},
ObjectMeta: metav1.ObjectMeta{
Name: types.ControllerRoleBindingName,
OwnerReferences: configmap.ObjectMeta.OwnerReferences,
},
Subjects: []rbacv1.Subject{{
Kind: "ServiceAccount",
Name: types.ControllerServiceAccountName,
}},
RoleRef: rbacv1.RoleRef{
Kind: "Role",
Name: types.ControllerRoleName,
},
},
{
TypeMeta: metav1.TypeMeta{
APIVersion: "rbac.authorization.k8s.io/v1",
Kind: "RoleBinding",
},
ObjectMeta: metav1.ObjectMeta{
Name: types.TransportRoleBindingName,
OwnerReferences: configmap.ObjectMeta.OwnerReferences,
},
Subjects: []rbacv1.Subject{{
Kind: "ServiceAccount",
Name: types.TransportServiceAccountName,
}},
RoleRef: rbacv1.RoleRef{
Kind: "Role",
Name: types.TransportRoleName,
},
},
}
for _, rolebinding := range rolebindings {
_, err = kube.CreateRoleBinding(namespace, &rolebinding, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
}
if cli.RouteClient != nil {
// routes: skupper-controller -> skupper
original, err := cli.RouteClient.Routes(namespace).Get(context.TODO(), "skupper-controller", metav1.GetOptions{})
if err == nil {
route := &routev1.Route{
TypeMeta: metav1.TypeMeta{
APIVersion: "v1",
Kind: "Route",
},
ObjectMeta: metav1.ObjectMeta{
Name: types.ConsoleRouteName,
OwnerReferences: original.ObjectMeta.OwnerReferences,
},
Spec: routev1.RouteSpec{
Path: original.Spec.Path,
Port: original.Spec.Port,
TLS: original.Spec.TLS,
To: routev1.RouteTargetReference{
Kind: "Service",
Name: types.ControllerServiceName,
},
},
}
_, err := cli.RouteClient.Routes(namespace).Create(context.TODO(), route, metav1.CreateOptions{})
if err != nil && !errors.IsAlreadyExists(err) {
return false, err
}
} else if !errors.IsNotFound(err) {
return false, err
}
// need to update edge and inter-router routes to point at different service:
err = kube.UpdateTargetServiceForRoute(types.EdgeRouteName, types.TransportServiceName, namespace, cli.RouteClient)
if err != nil {
return false, err
}
err = kube.UpdateTargetServiceForRoute(types.InterRouterRouteName, types.TransportServiceName, namespace, cli.RouteClient)
if err != nil {
return false, err
}
}
}
router, err := cli.KubeClient.AppsV1().Deployments(namespace).Get(context.TODO(), types.TransportDeploymentName, metav1.GetOptions{})
if err != nil {
return false, err
}
updateRouter := false
secret, err := cli.KubeClient.CoreV1().Secrets(namespace).Get(context.TODO(), types.LocalClientSecret, metav1.GetOptions{})
if err != nil {
return false, err
}
if !strings.EqualFold(string(secret.Data["connect.json"]), configs.ConnectJson(types.QualifiedServiceName(types.LocalTransportServiceName, namespace))) {
err = kube.DeleteSecret(types.LocalClientSecret, namespace, cli.KubeClient)
if err != nil {
return false, err
}
credential := types.Credential{
CA: types.LocalCaSecret,
Name: types.LocalClientSecret,
Subject: types.LocalTransportServiceName,
Hosts: []string{},
ConnectJson: true,
}
var owner *metav1.OwnerReference
if len(configmap.ObjectMeta.OwnerReferences) > 0 {
owner = &configmap.ObjectMeta.OwnerReferences[0]
}
_, err = kube.NewSecret(credential, owner, namespace, cli.KubeClient)
if err != nil {
return false, err
}
updateRouter = true
}
if renameFor050 {
// update deployment
// - serviceaccount
router.Spec.Template.Spec.ServiceAccountName = types.TransportServiceAccountName
// - mounted secrets:
kube.UpdateSecretVolume(&router.Spec.Template.Spec, "skupper-amqps", types.LocalServerSecret)
kube.UpdateSecretVolume(&router.Spec.Template.Spec, "skupper-internal", types.SiteServerSecret)
kube.UpdateSecretVolume(&router.Spec.Template.Spec, "skupper-proxy-certs", types.OauthRouterConsoleSecret)
// -oauth proxy sidecar
updateOauthProxyServiceAccount(&router.Spec.Template.Spec, types.TransportServiceAccountName)
updateRouter = true
}
desiredRouterImage := images.GetRouterImageName()
if router.Spec.Template.Spec.Containers[0].Image != desiredRouterImage {
router.Spec.Template.Spec.Containers[0].Image = desiredRouterImage
updateRouter = true
}
if kube.CheckProbesForTransportContainer(&router.Spec.Template.Spec.Containers[0]) {
updateRouter = true
}
configSync := ConfigSyncContainer()
if !hasContainer(configSync.Name, router.Spec.Template.Spec.Containers) {
err = kube.UpdateRole(namespace, types.TransportRoleName, types.TransportPolicyRule, cli.KubeClient)
if err != nil {
return false, err
}
router.Spec.Template.Spec.Containers = append(router.Spec.Template.Spec.Containers, *configSync)
updateRouter = true
}
if router.Spec.Template.Spec.Containers[1].Image != configSync.Image {
router.Spec.Template.Spec.Containers[1].Image = configSync.Image
updateRouter = true
}
if kube.CheckProbesForConfigSync(&router.Spec.Template.Spec.Containers[1]) {
updateRouter = true
}
if renamedSkRouter {
// Updating QDROUTERD_CONF env var
envQdrouterdConf := kube.GetEnvVarForDeployment(router, "QDROUTERD_CONF")
envQdrouterdConf = strings.ReplaceAll(envQdrouterdConf, "qpid-dispatch", "skupper-router")
envQdrouterdConf = strings.ReplaceAll(envQdrouterdConf, "qdrouterd", "skrouterd")
kube.SetEnvVarForDeployment(router, "QDROUTERD_CONF", envQdrouterdConf)
// Updating volume mount paths
for i, volume := range router.Spec.Template.Spec.Containers[0].VolumeMounts {
volume.MountPath = strings.ReplaceAll(volume.MountPath, "qpid-dispatch", "skupper-router")
router.Spec.Template.Spec.Containers[0].VolumeMounts[i] = volume
}
updateRouter = true
}
if addCertsSharedVolume {
kube.AppendSharedVolume(&router.Spec.Template.Spec.Volumes, []*[]corev1.VolumeMount{&router.Spec.Template.Spec.Containers[0].VolumeMounts, &router.Spec.Template.Spec.Containers[1].VolumeMounts}, "skupper-router-certs", "/etc/skupper-router-certs")
updateRouter = true
}
if addClaimsSupport {
if !config.IsEdge() {
if usingRoutes {
err = cli.createClaimsRedemptionRoute(ctx, namespace)
if err != nil {
return false, err
}
}
}
}
if moveClaims {
err = kube.UpdateRole(namespace, types.TransportRoleName, types.TransportPolicyRule, cli.KubeClient)
if err != nil {
return false, err
}
if err := cli.moveClaimsToRouterService(ctx, namespace); err != nil {
return false, err
}
latest, err := kube.WaitDeploymentReady(types.TransportDeploymentName, namespace, cli.KubeClient, time.Minute, time.Second)
if err != nil {
return false, err
}
if latest.ObjectMeta.ResourceVersion != router.ObjectMeta.ResourceVersion {
latest.Spec = router.Spec
router = latest
}
kube.AppendSecretVolumeWithVolumeName(&router.Spec.Template.Spec.Volumes, &router.Spec.Template.Spec.Containers[1].VolumeMounts, types.SiteServerSecret, "claims-cert", "/etc/skupper-internal/")
updateRouter = true
} else if updateRole {
err = kube.UpdateRole(namespace, types.TransportRoleName, types.TransportPolicyRule, cli.KubeClient)
if err != nil {
return false, err
}
}
if updateRouter || updateSite || hup {
if !updateRouter {
// need to trigger a router redployment to pick up the revised metadata field
touch(router)
updateRouter = true
}
_, err = cli.KubeClient.AppsV1().Deployments(namespace).Update(context.TODO(), router, metav1.UpdateOptions{})
if err != nil {
return false, err
}
if routerExposedAsIp {
fmt.Println("Sites previously linked to this one will require new tokens")
}
}
controller, err := cli.KubeClient.AppsV1().Deployments(namespace).Get(context.TODO(), types.ControllerDeploymentName, metav1.GetOptions{})
if err != nil {
return false, err
}
updateController := false
if renameFor050 {
// update deployment
// - serviceaccount
controller.Spec.Template.Spec.ServiceAccountName = types.ControllerServiceAccountName
// - mounted secrets:
kube.UpdateSecretVolume(&controller.Spec.Template.Spec, "skupper", types.LocalClientSecret)
kube.UpdateSecretVolume(&controller.Spec.Template.Spec, "skupper-controller-certs", types.ConsoleServerSecret)
// -oauth proxy sidecar
updateOauthProxyServiceAccount(&controller.Spec.Template.Spec, types.ControllerServiceAccountName)
updateController = true
}
if addMultiportServices {
// disabling the controller
controller, err = setAndWaitControllerReplicas(cli, 0, namespace)
if err != nil {
return false, err
}
if err = multiportConvertServices(ctx, cli, namespace); err != nil {
return false, err
}
if err = updateGatewayMultiport(ctx, cli); err != nil {
return false, err
}
updateController = true
}
// check if old cluster role & role binding exists
if deleted, _ := kube.DeleteClusterRole("skupper-service-controller", cli.KubeClient); deleted {
addClusterPolicy = true
}
if deleted, _ := kube.DeleteClusterRoleBinding(fmt.Sprintf("skupper-service-controller-%s", namespace), cli.KubeClient); deleted {
addClusterPolicy = true
}
// Add ClusterRoleBinding to allow reading SkupperClusterPolicies (otherwise policy will be disabled)
if addClusterPolicy {
siteConfig, _ := cli.SiteConfigInspectInNamespace(ctx, nil, namespace)
if siteConfig != nil {
siteOwnerRef := asOwnerReference(siteConfig.Reference)
var ownerRefs []metav1.OwnerReference
if siteOwnerRef != nil {
ownerRefs = []metav1.OwnerReference{*siteOwnerRef}
}
policyValidator := NewClusterPolicyValidator(cli)
for _, clusterRole := range cli.ClusterRoles(siteConfig.Spec.EnableClusterPermissions) {
// optional (in case of failure, cluster admin can add necessary cluster roles manually)
kube.CreateClusterRole(clusterRole, cli.KubeClient)
}
for _, clusterRoleBinding := range ClusterRoleBindings(namespace, siteConfig.Spec.EnableClusterPermissions) {
clusterRoleBinding.ObjectMeta.OwnerReferences = ownerRefs
_, err = kube.CreateClusterRoleBinding(clusterRoleBinding, cli.KubeClient)
if err != nil && !errors.IsAlreadyExists(err) {
if policyValidator.Enabled() {
log.Printf("unable to define cluster role binding - %v", err)
break
}
}
}
}
}
if updateRouterPolicyRule {
err = kube.UpdateRole(namespace, types.TransportRoleName, types.TransportPolicyRule, cli.KubeClient)
if err != nil {
return false, err
}
}
if substituteFlowCollector {
siteConfig, _ := cli.SiteConfigInspectInNamespace(ctx, nil, namespace)
if siteConfig.Spec.EnableConsole {
err = convertSiteConfigToCollectorEnabled(ctx, cli, namespace)
if err != nil {
return false, err
}
err = createNodeClusterRoleRule(ctx, cli, namespace)
if err != nil {
log.Printf("unable to update cluster role for nodes resource")
}
if siteConfig.Spec.AuthMode != string(types.ConsoleAuthModeOpenshift) {
err = updateControllerPorts(ctx, cli, namespace)
if err != nil {
return false, err
}
}
err = createFlowCollectorSidecar(ctx, cli, controller)
if err != nil {
return false, err
}
updateController = true
}
}
if addPrometheusServer {
siteConfig, _ := cli.SiteConfigInspectInNamespace(ctx, nil, namespace)
if siteConfig.Spec.EnableFlowCollector && siteConfig.Spec.PrometheusServer.ExternalServer == "" {
van := types.RouterSpec{
Namespace: namespace,
}
cli.GetVanPrometheusServerSpec(siteConfig.Spec, &van)
err := configureDeployment(&van.PrometheusServer, &siteConfig.Spec.Controller.Tuning)
if err != nil {
return false, err
}
err = cli.createPrometheus(ctx, siteConfig, van)
if err != nil {
return false, err
}
}
}
desiredControllerImage := images.GetServiceControllerImageName()
if controller.Spec.Template.Spec.Containers[0].Image != desiredControllerImage {
controller.Spec.Template.Spec.Containers[0].Image = desiredControllerImage
updateController = true
}
desiredCollectorImage := images.GetFlowCollectorImageName()
if len(controller.Spec.Template.Spec.Containers) > 1 {
if controller.Spec.Template.Spec.Containers[1].Image != desiredCollectorImage {
controller.Spec.Template.Spec.Containers[1].Image = desiredCollectorImage
updateController = true
}
}
desiredOauthProxyImage := images.GetOauthProxyImageName()
for i, container := range controller.Spec.Template.Spec.Containers {
if container.Name == "oauth-proxy" {
if controller.Spec.Template.Spec.Containers[i].Image != desiredOauthProxyImage {
controller.Spec.Template.Spec.Containers[i].Image = desiredOauthProxyImage
updateController = true
}
}
}
prometheus, err := cli.KubeClient.AppsV1().Deployments(namespace).Get(context.TODO(), types.PrometheusDeploymentName, metav1.GetOptions{})
updatePrometheus := false
if err == nil {
desiredPrometheusImage := images.GetPrometheusServerImageName()
if desiredPrometheusImage != prometheus.Spec.Template.Spec.Containers[0].Image {
prometheus.Spec.Template.Spec.Containers[0].Image = desiredPrometheusImage
touch(prometheus)
_, err = cli.KubeClient.AppsV1().Deployments(namespace).Update(context.TODO(), prometheus, metav1.UpdateOptions{})
if err != nil {
return false, err
}
updatePrometheus = true
}
} else if !errors.IsNotFound(err) {
return false, err
}
if kube.CheckProbesForControllerContainer(&controller.Spec.Template.Spec.Containers[0]) {
updateController = true
}
if updateController || hup {
if !updateController {
// trigger redeployment of service-controller to pick up latest image
touch(controller)
updateController = true
}
replicas := int32(1)
controller.Spec.Replicas = &replicas
_, err = cli.KubeClient.AppsV1().Deployments(namespace).Update(context.TODO(), controller, metav1.UpdateOptions{})
if err != nil {
return false, err
}
if consoleUsesLoadbalancer {
host := ""
for i := 0; host == "" && i < 120; i++ {
if i > 0 {
time.Sleep(time.Second)
}
service, err := kube.GetService(types.ControllerServiceName, namespace, cli.KubeClient)
if err != nil {
fmt.Println("Could not determine new console url:", err.Error())
break
}
host = kube.GetLoadBalancerHostOrIP(service)
}
if host != "" {
fmt.Println("Console is now at", "http://"+host+":8080")
}
}
}
if renameFor050 {
// delete old resources
if cli.RouteClient != nil {
err = cli.RouteClient.Routes(namespace).Delete(context.TODO(), "skupper-controller", metav1.DeleteOptions{})
if err != nil && !errors.IsNotFound(err) {
return false, err
}
}
services := []string{
"skupper-messaging",
"skupper-controller",
}
if usingRoutes {
// only delete skupper-internal if using
// routes, as otherwise previously issued
// tokens will reference it
services = append(services, "skupper-internal")
}
for _, service := range services {
err = cli.KubeClient.CoreV1().Services(namespace).Delete(context.TODO(), service, metav1.DeleteOptions{})
if err != nil && !errors.IsNotFound(err) {
return false, err
}
}
secrets := []string{
"skupper",
"skupper-amqps",
"skupper-ca",
"skupper-internal",
"skupper-internal-ca",
}
for _, secret := range secrets {
err = cli.KubeClient.CoreV1().Secrets(namespace).Delete(context.TODO(), secret, metav1.DeleteOptions{})
if err != nil && !errors.IsNotFound(err) {
return false, err
}
}
rolebindings := []string{
"skupper-proxy-controller-skupper-edit",
"skupper-skupper-view",
}
for _, rolebinding := range rolebindings {
err = cli.KubeClient.RbacV1().RoleBindings(namespace).Delete(context.TODO(), rolebinding, metav1.DeleteOptions{})
if err != nil && !errors.IsNotFound(err) {
return false, err
}
}
serviceAccounts := []string{
"skupper",
"skupper-proxy-controller",
}
for _, serviceAccount := range serviceAccounts {
err = cli.KubeClient.CoreV1().ServiceAccounts(namespace).Delete(context.TODO(), serviceAccount, metav1.DeleteOptions{})
if err != nil && !errors.IsNotFound(err) {
return false, err
}
}
roles := []string{
"skupper-edit",
"skupper-view",
}
for _, role := range roles {
err = cli.KubeClient.RbacV1().Roles(namespace).Delete(context.TODO(), role, metav1.DeleteOptions{})
if err != nil && !errors.IsNotFound(err) {
return false, err
}
}
}
if inprogress {
err = cli.updateCompleted(namespace)
if err != nil {
return true, err
}
}
return updateRouter || updateController || updateSite || updatePrometheus, nil
}
func (cli *VanClient) renameRouterConfigFile(namespace string) (bool, error) {
if namespace == "" {
namespace = cli.Namespace
}
cm, err := kube.GetConfigMap(types.TransportConfigMapName, namespace, cli.KubeClient)
if err != nil {
return false, err
}
configFile, okOld := cm.Data["qdrouterd.json"]
_, okNew := cm.Data[types.TransportConfigFile]
// renaming
if okOld && !okNew {
updConfigFile := strings.ReplaceAll(configFile, "qpid-dispatch", "skupper-router")
cm.Data[types.TransportConfigFile] = updConfigFile
delete(cm.Data, "qdrouterd.json")
_, err = cli.KubeClient.CoreV1().ConfigMaps(cli.Namespace).Update(context.TODO(), cm, metav1.UpdateOptions{})
if err != nil {
return false, err
}
return true, nil
} else {
return false, nil
}
}
func setAndWaitControllerReplicas(cli *VanClient, replicas int32, namespace string) (*appsv1.Deployment, error) {
controller, err := cli.KubeClient.AppsV1().Deployments(namespace).Get(context.TODO(), types.ControllerDeploymentName, metav1.GetOptions{})
if *controller.Spec.Replicas > 0 {
controller.Spec.Replicas = &replicas
_, err = cli.KubeClient.AppsV1().Deployments(namespace).Update(context.TODO(), controller, metav1.UpdateOptions{})
controller, err = kube.WaitDeploymentReadyReplicas(types.ControllerDeploymentName, namespace, int(replicas), cli.KubeClient, time.Minute, time.Second)
if err != nil {
return controller, err
}
}
return controller, err
}
func multiportConvertServices(ctx context.Context, cli *VanClient, namespace string) error {
servicesCm, err := cli.KubeClient.CoreV1().ConfigMaps(namespace).Get(context.TODO(), types.ServiceInterfaceConfigMap, metav1.GetOptions{})
if err != nil {
return err
}
v1Svcs := []types.ServiceInterfaceV1{}
for _, v := range servicesCm.Data {
v1Svc := types.ServiceInterfaceV1{}
err = json.Unmarshal([]byte(v), &v1Svc)
if err != nil {
return err
}
v1Svcs = append(v1Svcs, v1Svc)
}
outBytes, _ := json.Marshal(v1Svcs)
defs := &types.ServiceInterfaceList{}
err = defs.ConvertFrom(string(outBytes))
if err != nil {
return err
}
for _, svc := range *defs {
svcBytes, _ := json.Marshal(svc)
servicesCm.Data[svc.Address] = string(svcBytes)
_, err = cli.KubeClient.CoreV1().ConfigMaps(namespace).Update(context.TODO(), servicesCm, metav1.UpdateOptions{})
if err != nil {
return err
}
servicesCm, _ = cli.KubeClient.CoreV1().ConfigMaps(namespace).Get(context.TODO(), types.ServiceInterfaceConfigMap, metav1.GetOptions{})
}
return err
}
func updateGatewayMultiport(ctx context.Context, cli *VanClient) error {
// retrieving all service definitions
svcList, _ := cli.ServiceInterfaceList(ctx)
svcMap := map[string]*types.ServiceInterface{}
for _, svc := range svcList {
svcMap[svc.Address] = svc
}
gwList, _ := cli.GatewayList(ctx)
for _, gw := range gwList {
// updating local gateways
gatewayDir := getDataHome() + "/skupper/" + gw.Name
newGatewayDir := getDataHome() + gatewayClusterDir + gw.Name
// create the new base dir for gateways (and ignore errors if it already exists)
_ = os.MkdirAll(getDataHome()+gatewayClusterDir, 0755)
gd, err := os.Stat(gatewayDir)
ngd, nerr := os.Stat(newGatewayDir)
moveFiles := err == nil && gd != nil && gd.IsDir() && nerr != nil && ngd == nil
if moveFiles {
// renaming to new place
err = os.Rename(gatewayDir, newGatewayDir)
if err != nil {
return err
}
// generate a router id and store it for subsequent template updates
routerId := newUUID()
err = os.WriteFile(newGatewayDir+"/config/routerid.txt", []byte(routerId), 0644)
if err != nil {
return err
}
updateFileContent := func(fileName, oldPath, newPath string) error {
content, err := os.ReadFile(fileName)
if err != nil {
return err
}
updatedContent := strings.ReplaceAll(string(content), oldPath, newPath)
err = os.WriteFile(fileName, []byte(updatedContent), 0)
if err != nil {
return err
}
return nil
}
// Updating paths in service files
err = updateFileContent(fmt.Sprintf("%s/user/%s.service", newGatewayDir, gw.Name), getDataHome()+"/skupper/", getDataHome()+gatewayClusterDir)
if err != nil {
return err
}
err = updateFileContent(getConfigHome()+"/systemd/user/"+gw.Name+".service", getDataHome()+"/skupper/", getDataHome()+gatewayClusterDir)
if err != nil {
return err
}
cmd := exec.Command("systemctl", "--user", "daemon-reload")
err = cmd.Run()
if err != nil {
return fmt.Errorf("Unable to user service daemon-reload: %w", err)
}
cmd = exec.Command("systemctl", "--user", "restart", gw.Name+".service")
err = cmd.Run()
if err != nil {
return fmt.Errorf("Unable to user service restart: %w", err)
}
}
// updating router config to fix bad template issues
configmap, err := kube.GetConfigMap(gatewayPrefix+gw.Name, cli.GetNamespace(), cli.KubeClient)
if err != nil {
return err
}
gatewayConfig, err := qdr.GetRouterConfigFromConfigMap(configmap)
if err != nil {
return err
}
// updating version
sm := qdr.SiteMetadata{}
err = json.Unmarshal([]byte(gatewayConfig.Metadata.Metadata), &sm)
if err != nil {
return err
}
sm.Version = version.Version
smStr, err := json.Marshal(sm)
if err != nil {
return err
}
gatewayConfig.Metadata.Metadata = string(smStr)
// updating tcp listeners
newTcpListeners := qdr.TcpEndpointMap{}
for k, v := range gatewayConfig.Bridges.TcpListeners {
name := fmt.Sprintf("%s:%d", k, svcMap[v.Address].Ports[0])
v.Name = name
v.Address = fmt.Sprintf("%s:%d", v.Address, svcMap[v.Address].Ports[0])
newTcpListeners[name] = v
}
gatewayConfig.Bridges.TcpListeners = newTcpListeners
// updating tcp connectors
newTcpConnectors := qdr.TcpEndpointMap{}
for k, v := range gatewayConfig.Bridges.TcpConnectors {
name := fmt.Sprintf("%s:%d", k, svcMap[v.Address].Ports[0])
v.Name = name
v.Address = fmt.Sprintf("%s:%d", v.Address, svcMap[v.Address].Ports[0])
newTcpConnectors[name] = v
}
gatewayConfig.Bridges.TcpConnectors = newTcpConnectors
// updating http listeners
newHttpListeners := qdr.HttpEndpointMap{}
for k, v := range gatewayConfig.Bridges.HttpListeners {
name := fmt.Sprintf("%s:%d", k, svcMap[v.Address].Ports[0])
v.Name = name
v.Address = fmt.Sprintf("%s:%d", v.Address, svcMap[v.Address].Ports[0])
newHttpListeners[name] = v
}
gatewayConfig.Bridges.HttpListeners = newHttpListeners