Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to have persistent notifiers #17

Closed
skx opened this issue Apr 24, 2018 · 0 comments
Closed

It should be possible to have persistent notifiers #17

skx opened this issue Apr 24, 2018 · 0 comments

Comments

@skx
Copy link
Owner

skx commented Apr 24, 2018

Right now there are three notifiers:

  • IRC
  • MQ
  • Purppura

The first two do the same thing when a notification happens:

  • Join/connect to a server
  • Send a notification.
  • Disconnect

It would be neater if they could join in their constructor, and remain connected thereafter.

  • So the IRC notifier would join the channel and idle
  • The MQ notifier would connect to the queue.

And only at the notification stage would they actually notify. I'd suggest changing/extending the notifier class to have:

  • Setup()
  • Notify()

In the case of purppura the Setup() method would be a NOP, but for IRC/MQ they would join/connect there, and trigger notifications on demand via those persistent connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant