-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skybrud Redirects does not redirect when Error404Collection is set up #169
Comments
@vkuybida I am running into the same issue. I have just noticed that when using Error404Collection, even though this functionality does work and the custom page shows, it is actually setting the status code to 200, not 404 like the default one does. I have feeling this is what is causing the redirects to not work, as obviously if there was a successful 200 response, skybrud would just ignore (as expected). I am just looking into why Error404Collection sets a 200 response at my end right now, if i find anything I will post here and let you know. |
thanks. at this point, as workaround, I implemented custom ContentLastChanceFinder where handle Skybrud redirects and 404 errors. It works fine. Task IContentFinder.TryFindContent(IPublishedRequestBuilder request)
} |
This is an issue with Umbraco, as it accidentally sets a 200 OK status code. It should be fixed in 11.3, which was out earlier today: |
great to hear, thanks for the info |
Awesome thanks @abjerner - yes I've just confirmed upgrading to Umbraco 11.3 now correctly sets a 404 when using Error404Collection, meaning Skybrud now works as expected. Thanks for your help and the great package. 👍 |
Which version of Skybrud Redirects are you using? (Please write the exact version, example: 4.0.8)
4.0.8
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
11.2.2
Bug description
Skybrud Redirects does not redirect when Error404Collection is set up. It shows 404 error.
Without 404 redirects it works fine.
The text was updated successfully, but these errors were encountered: