Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to more recent React Native version #8

Open
blainemuri opened this issue Nov 6, 2017 · 1 comment
Open

Upgrade to more recent React Native version #8

blainemuri opened this issue Nov 6, 2017 · 1 comment

Comments

@blainemuri
Copy link

Current configuration only works on React-Native 0.47.2 or earlier. To have this work on 0.48.x and above, please update the imports of the RCTSFSafariViewController.h file:

Current:

#import <React/RCTBridgeModule.h>
#import <React/RCTConvert.h>
#import <React/RCTEventDispatcher.h>
#import <UIKit/UIKit.h>

Updated:

#import <React/RCTConvert.h>
#import <React/RCTEventDispatcher.h>
#import <UIKit/UIKit.h>


#if __has_include(<React/RCTBridgeModule.h>)
  #import <React/RCTBridgeModule.h>
#else
  #import "RCTBridgeModule.h"
#endif
``
@skycocker
Copy link
Owner

@blainemuri can you provide a pull request? it'll be way better this way, since you already know what to do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants