Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis must do builds with modules enabled and with modules disabled. #373

Open
amherag opened this issue Feb 25, 2021 · 1 comment
Open

Comments

@amherag
Copy link
Collaborator

amherag commented Feb 25, 2021

We need Travis to test the installation of CX with go build -mod=vendor and without the flag, i.e. go build. We need to test that the installation works with the current vendored modules and with modules that get downloaded.

@SkycoinSynth SkycoinSynth changed the title Travis checks with and without go modules Travis must do builds with modules enabled and with modules disabled. Feb 25, 2021
@SkycoinSynth
Copy link
Contributor

Travis must do builds with modules enabled and with modules disabled.

Some users will have problems and it will work for other users.


There is no excuse however, why golang goes to network, without first checking if dependencies are in the local vendor folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants