Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CX binary path is hardcoded in cx tests #392

Closed
ivankonevv opened this issue Feb 26, 2021 · 4 comments
Closed

CX binary path is hardcoded in cx tests #392

ivankonevv opened this issue Feb 26, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@ivankonevv
Copy link
Contributor

make test and make test-full always looks for a binary file in the $HOME/go/bin directory, no matter where the binary file is installed. Сhanging the GOPATH or GOBIN does not work. The problem lies somewhere in the tests themselves.

@jdknives
Copy link
Member

@ivankonevv thanks for the ticket. The problem is correctly identified. In the future, please use a more descriptive title. In this case something such as hardcoded cx binary location breaks make test would have been more appropriate.

@jdknives jdknives changed the title make test CX binary path is hardcoded in cx tests Feb 26, 2021
@jdknives jdknives added the bug Something isn't working label Feb 26, 2021
@jdknives
Copy link
Member

https://github.com/jdknives/cx/blob/9bc1891f8ae212d88c12d191b8bbbf8b3ec20aa6/tests/main.cx#L28

This logic here needs to be fixed to point to ./bin.

@ivankonevv
Copy link
Contributor Author

Solved

@jdknives
Copy link
Member

Tackled in #398 and copied to #414. Fixed in #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants