Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmsgpty-ui cannot work with https/wss. #206

Closed
evanlinjin opened this issue Mar 6, 2020 · 0 comments · Fixed by #208
Closed

Dmsgpty-ui cannot work with https/wss. #206

evanlinjin opened this issue Mar 6, 2020 · 0 comments · Fixed by #208
Assignees
Labels
bug Something isn't working

Comments

@evanlinjin
Copy link
Contributor

evanlinjin commented Mar 6, 2020

Describe the bug
As mentioned by @Senyoret1 on Telegram:

I made the terminal UI work, but there is a problem: the HTML with the terminal UI is in a http URL, but the manager has to be openned in a https URL, because the session cookie used by the manager is set as a secure cookie, so it only works in https URLS and is needed for the autentication mechanism of the Hypervisor to work. This means that the terminal UI can not be openned in the mnanager while the Hypervisor auth is enabled. The 2 options we have are: making the session cookie of the hypervisor work in http connections (quick fix but insecure) or make the hypervisor serve the terminal UI in a https URL. There could be a third option, which is recreating the terminal UI in the manager, but I tried to do it today and was unable to do it. I can continue trying, but I'm not sure if the hypervisor will accept a wss connection, so may not be possible.

The temporal solution I have for now is this: using the new terminal UI when using http connections and the current terminal UI when using https connections. This is not ideal because users are soposed to use the auth options of the Hypervisor and, because of that, a https connection, but works for testing. Also, something interesting about this is that the new terminal UI is not really good for mobile devices and, as the manager is responsive, the current terminal UI could still be used in mobile devices, even after solving the problems with the new UI.

Now, talking about serving content, maybe it would be good to start working on how to make the hypervisor serve the manager, like the Skycoin node serves the desktop wallet. It is something simple to do with http, but if https connections are going to be used, I'm not sure, but it could be a bit complicated to implement.

Appart from that, I have still not worked on the updater, as I invested more time than expected trying to make the terminal UI work with the current conditions. However, I did take a quick look and, at least from the manager perspective, it appeas to be a simple API endpoint, so there should not be much trouble implementing it. The only thing that worries me is that I don't know if there is a way to know is the visor needs to be updated, so the user knows when to use the option.

Environment information:
Independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant