Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault api error #156

Closed
nstringham opened this issue Nov 21, 2020 · 8 comments
Closed

vault api error #156

nstringham opened this issue Nov 21, 2020 · 8 comments

Comments

@nstringham
Copy link
Contributor

nstringham commented Nov 21, 2020

Describe the bug
SkyCrypt incorrectly says that I have disabled the API for vault

Profile/Location
https://sky.shiiyu.moe/stats/Cookie_Wookie_7/Apple

Additional Info
I have never used my vault

Expected behavior
The notice should not appear when the API is enabled

Screenshots
image
image

@project-bot project-bot bot added this to To do in Issues and PRs Nov 21, 2020
@metalcupcake5
Copy link
Member

Could be because you haven't unlocked the personal vault, or because there is nothing in the personal vault.

@nstringham
Copy link
Contributor Author

Could be because you haven't unlocked the personal vault, or because there is nothing in the personal vault.

Yes probably but the error message should be changed in that case

@metalcupcake5
Copy link
Member

ok pretty sure the api is just wack

@nstringham
Copy link
Contributor Author

I think the problem is that SkyCrypt assumes that just because there is no vault data the api is disabled

@WarpWing
Copy link
Contributor

@nstringham This still happening?

@nstringham
Copy link
Contributor Author

@nstringham This still happening?

Hard to say because I no longer have a profile that hasn't unlocked the vault but I don't think this has been fixed so it's probably still broken

@WarpWing
Copy link
Contributor

@nstringham This still happening?

Hard to say because I no longer have a profile that hasn't unlocked the vault but I don't think this has been fixed so it's probably still broken

It could have been fixed in a later update. If you have a friend or a profile that is close, would be dope if you could check. This should have been patched.

@dukio
Copy link
Contributor

dukio commented Oct 28, 2021

Tested on a new profile I made:

  • Vault API off: personal_vault_contents not in profile (doesn't matter if locked, unlocked or with items inside)
  • Vault API on: personal_vault_contents in profile (even before unlocking the vault ingame)

With the API on the profile on SkyCrypt doesn't show any warning, with the API off the profile on SkyCrypt shows the warning (all as expected).

Closing because this doesn't seem to be an issue anymore.


Vault API on:
image

Vault API off:
image

@dukio dukio closed this as completed Oct 28, 2021
Issues and PRs automation moved this from To do to Done Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants