Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balloon.isShowing is not set to false when ShowCounts is reached #168

Closed
BIMseven opened this issue Mar 17, 2021 · 2 comments
Closed

Balloon.isShowing is not set to false when ShowCounts is reached #168

BIMseven opened this issue Mar 17, 2021 · 2 comments
Assignees
Labels
bug Something isn't working Released Released already on the latest version.

Comments

@BIMseven
Copy link

BIMseven commented Mar 17, 2021

Please complete the following information:

  • Library Version 1.3.3
  • Affected Device(s) All

Describe the Bug:

Calling show() method on a Balloon for the first time sets isShowing to true before checking if showTimes has been reached. If showTimes has been reached (determined by checking the ballon persistence cache) then .show() returns. After this point .isShowing returns true, even though it isn't.

Expected Behavior:
issue.txt

If showTimes has been reached, and the runIfReachedShowCounts callback in show() has been invoked, all following calls to Ballon.isShowing should return false.

@skydoves skydoves self-assigned this Mar 20, 2021
@skydoves skydoves added the bug Something isn't working label Mar 20, 2021
@skydoves
Copy link
Owner

Hi, @BIMseven!
This issue is pre-released on the 1.3.4-SNAPSHOT and it will be stably released on the next release.
Thanks for your issue :)

@skydoves skydoves added the Release Next This feature will be released on next version label Mar 20, 2021
@skydoves
Copy link
Owner

skydoves commented Apr 3, 2021

A new stable version 1.3.4 has been released.
Thanks for your issue :)

@skydoves skydoves added Released Released already on the latest version. and removed Release Next This feature will be released on next version labels Apr 3, 2021
@skydoves skydoves closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Released Released already on the latest version.
Projects
None yet
Development

No branches or pull requests

2 participants