Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomSheetDialogFragment - Feature Request #2

Closed
pauloaapereira opened this issue Feb 23, 2021 · 3 comments
Closed

BottomSheetDialogFragment - Feature Request #2

pauloaapereira opened this issue Feb 23, 2021 · 3 comments
Assignees

Comments

@pauloaapereira
Copy link

First of all thank you so much for this awesome library. Your code is, as usually, really well organized and useful.

Is your feature request related to a problem?

I was hoping to implement a BottomSheetDialogFragment, and to use DataBinding on it.
Since I am using Bindables, I was looking for a binding class that would extend already from the BottomSheetDialogFragment class.

Describe the solution you'd like:

I know it is not hard to apply some work around from my side to this, but I also think that this would be a good feature to be implemented and made available.

@pauloaapereira pauloaapereira changed the title BottomSheetDialogFragment BottomSheetDialogFragment - Feature Request Feb 23, 2021
@skydoves
Copy link
Owner

Thanks for your great issue :)
You can use BindingBottomSheetDialogFragment in the SNAPSHOT bindables:1.0.5-SNAPSHOT.

@skydoves skydoves self-assigned this Feb 23, 2021
@pauloaapereira
Copy link
Author

Thanks for your great issue :)
You can use BindingBottomSheetDialogFragment in the SNAPSHOT bindables:1.0.5-SNAPSHOT.

Thank you, I'll give it a try! :)

@pauloaapereira
Copy link
Author

Sorry for the late answer! I only managed to test it now.
Working fine, no issues so far.
Thanks! @skydoves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants