Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does this project compare to your other project MarvelHeroes in terms of Architecture esp MVVM side #8

Closed
rinav opened this issue May 16, 2020 · 2 comments

Comments

@rinav
Copy link

rinav commented May 16, 2020

I am little confused when comparing both your projects
As both use MVVM with Repository pattern and Coroutines what is the major difference between the two setup comparing only the architecture excluding the UI.

Thanks for sharing this great repo, It serves as a great reference point to building modern android app with good architecture implementation

@skydoves
Copy link
Owner

@rinav
Hi, thank you for your interest.

There is no major difference between DisneyMotions and MarvelHeroes in the architectural points.
I think you got confused because of the client from the MarvelHeros, the main role of the client is an implementation of a service and separating the network call from the repository.
This repository is a really really little sample implementation of the real architectural project in the real world and the concept of the client helps to unit testing easier in the network call.

@rinav
Copy link
Author

rinav commented May 16, 2020

@skydoves Yes you understood it right, that was probably what I was thinking. Thanks for the quick respons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants