Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context-receivers to reduced the number of parameters passed #2

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Use context-receivers to reduced the number of parameters passed #2

merged 3 commits into from
Jul 7, 2022

Conversation

qdsfdhvh
Copy link
Contributor

@qdsfdhvh qdsfdhvh commented Jul 7, 2022 

rememberContentWithOrbitaryScope {
  // Before
  Box(Modifier.animateXX(this, XXSpec)) { .. }
  // After
  Box(Modifier.animateXX(XXSpec)) { .. }
}

It will be easier to use.

@qdsfdhvh qdsfdhvh requested a review from skydoves as a code owner July 7, 2022 14:12
skydoves
skydoves requested changes Jul 7, 2022
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qdsfdhvh, overall looks great to me!
Could you please run the ./gradlew apiDump and push the changes before merging this PR? Thanks!

@qdsfdhvh
Copy link
Contributor Author

qdsfdhvh commented Jul 7, 2022

Hey @qdsfdhvh, overall looks great to me! Could you please run the ./gradlew apiDump and push the changes before merging this PR? Thanks!

Thanks, it has pushed.

@qdsfdhvh qdsfdhvh requested a review from skydoves July 7, 2022 14:33
skydoves
skydoves approved these changes Jul 7, 2022
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general really looks nice. Thank you for the contribution :)

@skydoves skydoves merged commit c2ea80f into skydoves:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qdsfdhvh @skydoves