Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow color is not changeable on Android 6 device #31

Closed
mikebikemusic opened this issue Jul 18, 2020 · 7 comments
Closed

Arrow color is not changeable on Android 6 device #31

mikebikemusic opened this issue Jul 18, 2020 · 7 comments
Assignees
Labels
released released already the last version

Comments

@mikebikemusic
Copy link

  • Library Version 1.0.9
  • Affected Device(s) [e.g. alps 06 with Android 6.0

Describe the Bug:

android:textColor="@color/colorDarkGreen"
android:background="@color/offWhite" (#eeeeee)
app:spinner_arrow_tint="@color/colorDarkGreen" (#00574B)

Arrow always shows white on older Android version. Even if I change spinner_arrow_tint to #000000

device-2020-07-18-104222

Expected Behavior:

Arrow color should be the same color as the text color, since both are set to the same value.
Arrow color is changeable on simulator and on Samsung A10.

@skydoves skydoves self-assigned this Jul 19, 2020
@skydoves
Copy link
Owner

Hi, @mikebikemusic!
I just updated the demo project code about the changing tint color of the arrow.
But I can't found any devices that happened that issue.
Could please you run the demo project on your device?
Thank you for your issue!

@mikebikemusic
Copy link
Author

In the demo project, I see the arrow color is now yellow, so that works. But now I see two differences:

First of all, the emulator shows that you only changed the arrow for the first spinner, which looks correct. But on the Android 6 device, all 3 spinners turn yellow.

A side effect is that when I choose yellow in the second spinner on the Android 6 device, the arrow disappears:

device-2020-07-19-072308

I suspect the change you made is good enough for me since I'm not currently planning using more than one spinner. Thank you for your quick response.

Mike

@mikebikemusic
Copy link
Author

I found that explicitly setting the spinner_arrow_tint to white_70 on the other two demo spinners is a workaround for Android 6.

@skydoves
Copy link
Owner

Thank you for your details!
Then the problem will be fixed If I change the default color of the arrow to the explicit color like white.
This resolve will be included in the next version.
Thank you for your issue :)

@skydoves skydoves added the Release Next This feature will be released on next version label Jul 19, 2020
@mikebikemusic
Copy link
Author

That sounds perfect. Thank you again.

@skydoves
Copy link
Owner

It is released a new version 1.1.0.
Thank you for your issue contribution and a coffee! ❤️

@skydoves skydoves added released released already the last version and removed Release Next This feature will be released on next version labels Jul 19, 2020
@mikebikemusic
Copy link
Author

Confirming fixed in my app with 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released released already the last version
Projects
None yet
Development

No branches or pull requests

2 participants