Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create README_JP.md #43

Merged
merged 4 commits into from Oct 9, 2022
Merged

Create README_JP.md #43

merged 4 commits into from Oct 9, 2022

Conversation

masah517
Copy link
Contributor

@masah517 masah517 commented Oct 9, 2022 •
edited

Guidelines

Added the Japanese language support for README files.
Ref: #40

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

@masah517 masah517 marked this pull request as ready for review October 9, 2022 13:46
skydoves
skydoves approved these changes Oct 9, 2022
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masah517 Looks good to me :)
Thank you for your contribution! 👍

@skydoves skydoves merged commit 58f9784 into skydoves:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masah517 @skydoves