Refactor Code

[devKshitijJain]

GithubFollows/app/src/main/java/com/skydoves/githubfollows/ApplicationClazz.kt

Line 24 in 966f1a3

DaggerAppComponent.builder()

Here you are calling

DaggerAppComponent.builder()
                .application(this)
                .build()
                .inject(this)

and then you are returning

override fun applicationInjector(): AndroidInjector<out DaggerApplication> {
        return DaggerAppComponent.builder().application(this).build()
    }

can't you just make a var for DaggerAppComponent.builder().application(this).build() and then just call inject on that above.

[skydoves]

Oh you mean like this?

class ApplicationClazz : DaggerApplication() {

    private val appComponent = DaggerAppComponent.builder()
            .application(this)
            .build()

    override fun onCreate() {
        super.onCreate()

        if (!LeakCanary.isInAnalyzerProcess(this)) {
            LeakCanary.install(this)
        }

        if(BuildConfig.DEBUG) {
            Timber.plant(Timber.DebugTree())
        }

        appComponent.inject(this)

        PreferenceComponent_PrefAppComponent.init(this)
    }

    override fun applicationInjector(): AndroidInjector<out DaggerApplication> {
        return appComponent
    }
}

I think it looks better than before too.
Thank you!!

If you want to contribute any codes or change something,
welcome to Pull Request! :)

[devKshitijJain]

Let's discuss the approach that you have followed. I think we can make the code more robust and better. Add me on FB @kjain9878

[devKshitijJain]

Refactored with PR

[skydoves]

okay, Thanks!!