Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Cleartext HTTP traffic not permitted on Android P #7

Merged
merged 1 commit into from Dec 26, 2018

Conversation

paolorotolo
Copy link
Contributor

@paolorotolo paolorotolo commented Dec 25, 2018

This PR fixes the "Cleartext HTTP traffic not permitted" on Android P: https://developer.android.com/training/articles/security-config#CleartextTrafficPermitted

Actually 2 fixes are available:

  • continue using HTTP APIs and allowing cleartext traffic in Andorid Manifest with:
android:usesCleartextTraffic="true"
  • Switch to HTTPS APIs.
    private const val BASE_POSTER_PATH = "https://image.tmdb.org/t/p/w342"
    private const val BASE_BACKDROP_PATH = "https://image.tmdb.org/t/p/w780"
    private const val YOUTUBE_VIDEO_URL = "https://www.youtube.com/watch?v="
    private const val YOUTUBE_THUMBNAIL_URL = "https://img.youtube.com/vi/"

This PR implements the second option.

Please review and merge.

@skydoves skydoves self-requested a review December 26, 2018 01:41
@skydoves
Copy link
Owner

@paolorotolo
Thank you for your PR!!

@skydoves skydoves merged commit f5c0028 into skydoves:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants