Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition for DialogFragment #16

Closed
XWayne opened this issue Sep 22, 2020 · 2 comments
Closed

Transition for DialogFragment #16

XWayne opened this issue Sep 22, 2020 · 2 comments

Comments

@XWayne
Copy link

XWayne commented Sep 22, 2020

Hey! This is awesome. As you mention in :#8 (comment)_ , how DialogFragment work?
Thank you a lot .

This library can be used only between View, Fragment, Activity, and DialogFragment.
Thank you :)

Originally posted by @skydoves in #8 (comment)

@skydoves
Copy link
Owner

skydoves commented Sep 29, 2020

Hi, @XWayne.
It works the same way as Fragment because the DialogFragment extends Fragment as a parent.
You can test using the demo project after changing that MainSingleDetailFragment extends Fragment.

@XWayne
Copy link
Author

XWayne commented Oct 9, 2020

Thanks . but I mean showing as a Dialog with transformation , instead of a simple Fragment

It just works as a plain Dialog without transformation after changing that MainSingleDetailFragment extends DialogFragment

image

I am quite confused , thanks a lot .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants