Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deltat.preds file downloads on every call to load.timescale() because file has expired and not been updated #170

Closed
DimitriosTheodorakis opened this issue Apr 2, 2018 · 3 comments
Assignees

Comments

@DimitriosTheodorakis
Copy link

When I run my code it downloads the de423.bsp and deltat.data files fine and then never again when I run it a second time.

However on every function call which uses a skyfield function it downloads deltat.preds and renames the old file deltat.old.preds. So after the program is complete I have over 48 preds files (and a slowed down program).

Any idea why this might be happening? I just updated to the latest version of skyfield.
The files all seem to have the same content...
load.timescale() seems to be causing this behaivour but I'm not sure if this is intended.

@DimitriosTheodorakis DimitriosTheodorakis changed the title deltat.preds file downloads on every call to function using skyfield deltat.preds file downloads on every call to load.timescale() because file has expired Apr 2, 2018
@DimitriosTheodorakis
Copy link
Author

On further inspection using log.load
Expired on: 2018-04-01
(for deltat.preds)

http://maia.usno.navy.mil/ser7/deltat.preds
Here the prediction column goes up to 2018.25 (around the end of March)

How often do these get updated? Can skyfield not tell it is downloading the same expired file?

@DimitriosTheodorakis DimitriosTheodorakis changed the title deltat.preds file downloads on every call to load.timescale() because file has expired deltat.preds file downloads on every call to load.timescale() because file has expired and not been updated Apr 2, 2018
@brandon-rhodes brandon-rhodes self-assigned this Apr 11, 2018
@brandon-rhodes
Copy link
Member

Thanks for the report! Before releasing the upcoming version of Skyfield, I'll figure out what's going on with that USNO file.

@brandon-rhodes
Copy link
Member

Thanks again for the report! I can't tell whether the USNO is updating those files any more, or whether we should now switch to another data source; but I'll first release a new Skyfield version with this fix to correct its behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants