Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source of ephemerides unclear #382

Closed
ghost opened this issue May 30, 2020 · 4 comments
Closed

Source of ephemerides unclear #382

ghost opened this issue May 30, 2020 · 4 comments
Assignees

Comments

@ghost
Copy link

ghost commented May 30, 2020

The Loader should indicate the URL it is downloading.

The docs should explain how Loader arrives at a URL.

@brandon-rhodes brandon-rhodes self-assigned this May 30, 2020
@brandon-rhodes
Copy link
Member

Agreed, there should be a call that maps files to URLs so that people can see the URL if they want. I'll document the call if it already exists, else add one!

@brandon-rhodes
Copy link
Member

@StephenCarboni — It looks easy to add a build_url(filename) method to the load object, so that interested users can ask which URL will be downloaded if they ask for a particular filename:

>>> load.build_url('de421.bsp')
'ftp://ssd.jpl.nasa.gov/pub/eph/planets/bsp/de421.bsp'

Would that be a sufficient resolution for the issue?

@ghost
Copy link
Author

ghost commented May 31, 2020

Looks good to me.

@brandon-rhodes
Copy link
Member

The feature will be in the next version of Skyfield. Thanks for the idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant