Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JulianDate.__eq__ crashes when not comparing to another JulianDate object #81

Closed
alexamici opened this issue Mar 17, 2016 · 3 comments
Closed
Assignees

Comments

@alexamici
Copy link

Comparing a JulianData object to anything else than another JulianDate object crashes with:

AttributeError: <type> object has no attribute 'tt'

I would have expected to simply return False.

I didn't test it, but it seems to me that even comparing two JulianDate objects with an array of times would crash due to the fact that numpy.ndarray's do not have a defined truth value.

@alexamici
Copy link
Author

I hit the problem on current release 0.6.1 and I just noticed that master contains some major refactoring, but bug is still present.

@brandon-rhodes
Copy link
Member

Thanks for letting me know about the problem!

@brandon-rhodes
Copy link
Member

I have just released Skyfield 0.8 with a fix for this issue. Thanks again for letting me know about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants