Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garminuino-App doesn't work with Google Maps 10.9.2 #10

Closed
Niklas04 opened this issue Feb 8, 2019 · 9 comments
Closed

Garminuino-App doesn't work with Google Maps 10.9.2 #10

Niklas04 opened this issue Feb 8, 2019 · 9 comments

Comments

@Niklas04
Copy link
Contributor

Niklas04 commented Feb 8, 2019

Hi,
I've updated Google Maps to Version 10.9.2 and Garminuino-App won't work anymore.
The HUD shows "Ok" but the navigation informations doesn't show up.

In the log I get the error "java.lang.NoSuchFieldException: No field mActions in class Landroid/app/Notification$BuilderRemoteViews; (declaration of 'android.app.Notification$BuilderRemoteViews' appears in /system/framework/framework.jar)"

I always try to figure out, where the problem could be.
The function
views.getClass() (processGoogleMapsNotification, NotificationMontitor.java)
doesn't get the class "android.widget.Remoteview" but get "android.app.Notification$BuilderRemoteViews".
In this class the Field "mActions" doesn't exist.

Don't have found any solution course of lack of experience.
I think Google made some changes to the structure of the notification.

@skyforcetw
Copy link
Owner

What is your version of Android?
I test Garminuino on my old phone runs 6.0 , it's works.
Does not test on 9.0(Pie).

@Niklas04
Copy link
Contributor Author

Niklas04 commented Feb 8, 2019

I've tested it on Android Version 9 and 8.1.0.
Do you have already installed Google Maps Version 10.9.2?

@skyforcetw
Copy link
Owner

I guess the package name of notify is changing from com.google.android.app.maps to com.google.android.gm, I will test the new package name later.

112129

@Niklas04
Copy link
Contributor Author

On my device the app shows still com.google.android.apps.maps

screenshot_20190210-173005

@skyforcetw
Copy link
Owner

My mistake, I ignore the com.google.android.apps.maps is exist on my phone....

@skyforcetw
Copy link
Owner

The original parsing method is based on Reflection, it's means only works on some hypothesis of Notification object self.

I add new parsing method based on Notification's extra, this is more safety & official mechanism to got we want.
I prefer parse extra first, only when no extra exist, change to Reflection.
Give me some time to modify the code.....

@skyforcetw
Copy link
Owner

skyforcetw commented Feb 11, 2019

Hi, I update code, it's works on gmap 10.9.2.

@Niklas04
Copy link
Contributor Author

Hi,
thanks for the quick fix.
I tested it and works all great with the new method - except showing the distance to turn.
I found the bug and will make a pull request.

Btw, nice new layout! Only the text size (option_text_size) is in my opinion too big, maybe 18sp or 20sp would be better.

@skyforcetw
Copy link
Owner

I think put a option to select text size is better ^^

skyforcetw pushed a commit that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants