Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error list does not match with skygear-server #49

Closed
bensonby opened this issue Aug 14, 2016 · 0 comments
Closed

Error list does not match with skygear-server #49

bensonby opened this issue Aug 14, 2016 · 0 comments
Assignees
@bensonby

Comments

@bensonby
Copy link
Contributor

bensonby commented Aug 14, 2016 •
edited
Loading

The error list in JS SDK: 274fbec#diff-b83d27d3c5374e6d6de83271284db8c4R16
The error list in skygear-server https://github.com/SkygearIO/skygear-server/blob/2fa211c93e4b0a70acf2ecaa42fef511cfa430ca/skyerr/skyerr.go#L35

  • The error code 109 in JS SDK is duplicated for Duplicated and ResourceNotFound. So all subsequent error codes are shifted by one.
  • A new error RecordQueryInvalid has been added to server side but not in the JS SDK
bensonby pushed a commit to bensonby/skygear-SDK-JS-1 that referenced this issue Aug 14, 2016
Update error code list to match server side
4c7fc37 
refs SkygearIO#49
@bensonby bensonby mentioned this issue Aug 14, 2016
Closed
@bensonby bensonby self-assigned this Aug 14, 2016
This was referenced Aug 14, 2016
Closed
Closed
rickmak pushed a commit that referenced this issue Aug 15, 2016
@rickmak
Fix error code list to match server side
3c54ac0 
refs #49
@rickmak rickmak closed this as completed Aug 15, 2016
bensonby pushed a commit to SkygearIO/skygear-doc that referenced this issue Aug 15, 2016
Fix error code list
4c3049e 
refs #102 SkygearIO/skygear-SDK-JS#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bensonby bensonby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rickmak @bensonby