NULL token saved to DB causing type error on send

[rickmak]

For unknown reason, the a NULL token is saved to _device table. And causing type error on sending push notification.

• Skygear Server Date/Version: v0.10
• Application Platform: portal user

Expected Results

The NULL will got rejected during save time.

Actual Results

Got following error on calling push:users

{
  "error": {
    "name": "UnexpectedError",
    "code": 10000,
    "message": "panic occurred while handling request: sql: Scan error on column index 2: unsupported driver -> Scan pair: <nil> -> *string"
  }
}

[cheungpat]

It appears that skydb save skydb.Device with NULL token if the request’s device_token field is empty. This is explicitly done this way. There is also test case that explicitly test that the handler accepts device with empty token.

Therefore, my opinion is to keep existing behavior and not reject device with empty token.