Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagrange crashes/locks-up for binary files incorrectly sent as "text/gemini` #601

Open
acidus99 opened this issue Jun 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@acidus99
Copy link

There are files in Geminispace incorrectly served with a text/gemini MIME type that are really binaries. Lagrange crashes, locks up, or becomes very slow when loading these URLs, depending on the version/platform (I've seen all 3 happen).

Here is a 14 MB Linux ELF executable, sent with an incorrect text/gemini MIME type

gemini://mkl-wlod.srht.site/repo/tree/scripts/.local/bin/gmnigit

As a fix, as mention in #600 you could use the MIME sniffing standards "mislabeled binary resource" rules to detect when text/gemini (and really any text/* MIME type) isn't really text, and not attempt to render it.

@skyjake skyjake added the bug Something isn't working label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants