Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minish Cap: "unlock" sound effect issue #315

Closed
RetroEdit opened this issue Aug 9, 2023 · 2 comments
Closed

Minish Cap: "unlock" sound effect issue #315

RetroEdit opened this issue Aug 9, 2023 · 2 comments
Labels
gba Game Boy Advance Core

Comments

@RetroEdit
Copy link

I noticed a general sound effect issue with Minish Cap. The "unlock" sound effect seems to output notes that are more shrill and short than on real console.

Reproduced on 104c287 on both Windows and Android, with and without BIOS.

Here's a comparison video. For testing, I used the early Business Scrub cutscene you get in the first few minutes of gameplay. First I ran the cutscene in SkyEmu, then I ran it in NanoBoyAdvance.

https://www.youtube.com/watch?v=d9TL7ItKl2k

Here's a savestate shortly right before the cutscene; you just have to press 'A' for the sound to be played: Legend of Zelda, The - The Minish Cap (USA).slot0.state.png.zip

@skylersaleh skylersaleh added the gba Game Boy Advance Core label Aug 17, 2023
@skylersaleh
Copy link
Owner

Thanks, was able to reproduce this issue. I'll start looking into it.

@skylersaleh
Copy link
Owner

Turns out I had a bad read mask on SOUNDCNT_X which made it look like the PSG notes finished playing immediately to the game, so the audio engine ended up playing the PSG notes way too quickly causing only small blips of the noise to come out.

@skylersaleh skylersaleh mentioned this issue Aug 25, 2023
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gba Game Boy Advance Core
Projects
None yet
Development

No branches or pull requests

2 participants