Negative numbers in SQL queries aren't properly normalized

[pvande]

This implies that if an unknown number is inlined into an SQL query, multiple traces may be generated for the same source query.

Failing test case:

diff --git a/spec/unit/normalizers/active_record_spec.rb b/spec/unit/normalizers/active_record_spec.rb
index 063a34e..5513750 100644
--- a/spec/unit/normalizers/active_record_spec.rb
+++ b/spec/unit/normalizers/active_record_spec.rb
@@ -65,6 +65,15 @@ module Skylight
       expect(desc).to eq("select * from foo where id = ?")
     end

+    it "Handles negative numbers in embedded binds" do
+      name, title, desc =
+        normalize(name: "Foo Load", sql: "select * from foo where id = -1")
+
+      expect(name).to eq("db.sql.query")
+      expect(title).to eq("SELECT FROM foo")
+      expect(desc).to eq("select * from foo where id = ?")
+    end
+
     it "handles some precomputed binds" do
       sql = %{INSERT INTO "agent_errors" ("body", "created_at", "value", "hostname", "reason") VALUES ($1, $2, NULL, $3, $4) RETURNING "id"}
       extracted = %{INSERT INTO "agent_errors" ("body", "created_at", "value", "hostname", "reason") VALUES (?, ?, ?, ?, ?) RETURNING "id"}

[wagenet]

Thanks for reporting this. It's a known issue on our end, though this is the first time anyone else has noticed it. Is it causing problem for you?

[pvande]

Unfortunately, it is, though not a significant one.

[wagenet]

This is fixed in the new SQL lexer that we're hoping to roll out soon.