Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Refactor test codes: blockkit #155

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Refactor test codes: blockkit #155

merged 4 commits into from
Nov 22, 2021

Conversation

skyoo2003
Copy link
Owner

@skyoo2003 skyoo2003 commented Nov 21, 2021

Thanks for contributing to kakaowork-py

Description

Removed duplicate test codes and added more cases to tests. Resolves #148

Checklist

  • [ ] Added a news fragment in the news directory to describe this fix with the issue or pr number and the extension such as .breaking, .feature, .enhancement, .bugfix, .deprecation, .removal, .doc or .misc. skipping
  • Added any related issues
  • Added tests for changed code.

@skyoo2003 skyoo2003 added maintenance This issue is for project maintenance. wip This issue or pull request is work in progress labels Nov 21, 2021
@skyoo2003 skyoo2003 self-assigned this Nov 21, 2021
@skyoo2003 skyoo2003 removed the maintenance This issue is for project maintenance. label Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #155 (b5ada84) into master (d6fdfed) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   89.46%   89.53%   +0.06%     
==========================================
  Files          11       11              
  Lines        1500     1500              
==========================================
+ Hits         1342     1343       +1     
+ Misses        158      157       -1     
Impacted Files Coverage Δ
kakaowork/blockkit.py 91.98% <0.00%> (+0.27%) ⬆️

@skyoo2003 skyoo2003 merged commit f3dc715 into master Nov 22, 2021
@skyoo2003 skyoo2003 deleted the refactor-tests branch November 22, 2021 07:55
@skyoo2003 skyoo2003 changed the title Refactoring test codes Refactoring tests: blockkit Nov 22, 2021
@skyoo2003 skyoo2003 removed the wip This issue or pull request is work in progress label Nov 22, 2021
@skyoo2003 skyoo2003 changed the title Refactoring tests: blockkit Refactor test codes: blockkit Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor pamametrizing tests
1 participant