Wrong include position in single_include header

[bmanga]

Ciao :)
The single include version of the library, there are usages of std::vector before it is included, causing a compile-time error.

[skypjack]

Hi there,

May I ask you to provide an example that makes it fail to compile?
I tried the current single include header online and it compiles fine without errors.
I've no clue on how to reproduce the issue you mentioned. You can freely reuse the online tool and drop here a link if you like. 👍

Thank you!

[indianakernick]

entt::radix_sort uses std::vector without including it. Perhaps that's the cause of the issue? Though I wasn't able to reproduce the error online because std::vector is defined by the time radix_sort is instantiated.

I noticed that some headers appear more than once in the single include header. For example core/algorithm.hpp appears twice core/config.hpp appears fifteen times. The file could be made a bit smaller by only keeping the first occurance.

[skypjack]

Wow @Kerndog73 how did you spot it? 😲

I noticed that some headers appear more than once in the single include header. For example core/algorithm.hpp appears twice core/config.hpp appears fifteen times. The file could be made a bit smaller by only keeping the first occurance.

Long story short: I use this file to prepare the single include header and I've from zero to no experience with python fortunately. So, I don't think I'll ever be able to modify it.
Of course, any PR is welcome if you want to try. :)

---

@bmanga

Was the include from algorithm.hpp your problem?

[indianakernick]

how did you spot it?

The first occurrence of #include <vector> is on line 1457 and the first occurence of std::vector is on line 270.

I've from zero to no experience with python fortunately. So, I don't think I'll ever be able to modify it.
Of course, any PR is welcome if you want to try. :)

I don't really have much experience either. Oh well.

[bmanga]

Weird, I don't remember how I encountered it and I can't find a way to trigger it anymore :(
Sorry for the false alarm, but I'm glad at least some improvement came out of it.

[skypjack]

That's fine @bmanga I added a commit to fix the missing include pointed out by @Kerndog73 👍
Please, leave the issue open. It will be closed automatically when I merge everything on master.

Thank you and feel free to contact me if you need. 😉