Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photometry handler: pandas warning #4765

Open
Theodlz opened this issue Feb 12, 2024 · 0 comments
Open

Photometry handler: pandas warning #4765

Theodlz opened this issue Feb 12, 2024 · 0 comments
Labels

Comments

@Theodlz
Copy link
Contributor

Theodlz commented Feb 12, 2024

#2648 added a line (L479) where if the origin of a photometry point is None, it is set to the string "None". I'm not sure why this is needed, but now it raises a pandas deprecation warning. In future releases, having None in a column will raise an error because the dtype of the column is float64 and so it doesnt know what to cast that string too.

We should make sure that the dtype of the origin column is string.

@Theodlz Theodlz added the bug label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant