Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rename noise keyword argument in redshifts_from_comoving_density function #478

Open
rrjbca opened this issue Aug 31, 2021 · 0 comments · May be fixed by #479
Open

ENH: Rename noise keyword argument in redshifts_from_comoving_density function #478

rrjbca opened this issue Aug 31, 2021 · 0 comments · May be fixed by #479
Labels
enhancement Improvement of existing feature good first issue Good for newcomers low priority module: galaxies

Comments

@rrjbca
Copy link
Contributor

rrjbca commented Aug 31, 2021

It was noted in the review for our JOSS paper that the keyword argument noise for the function redshifts_from_comoving_density has a misleading name. See the review comment here. They suggested renaming to fixed_N. My own suggestion would be shot_noise (or perhaps poisson). Since this would require a breaking API change, this should only be made as part of a future major release (if at all).

@rrjbca rrjbca added enhancement Improvement of existing feature good first issue Good for newcomers module: galaxies low priority labels Aug 31, 2021
@Lucia-Fonseca Lucia-Fonseca changed the title Rename noise keyword argument in redshifts_from_comoving_density function ENH: Rename noise keyword argument in redshifts_from_comoving_density function Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature good first issue Good for newcomers low priority module: galaxies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant