Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Empty Embed Descriptions get rendered #180

Closed
itohatweb opened this issue Dec 6, 2021 · 2 comments
Closed

bug: Empty Embed Descriptions get rendered #180

itohatweb opened this issue Dec 6, 2021 · 2 comments

Comments

@itohatweb
Copy link

Describe the bug
When creating a discord-embed with no description discord-components still adds a discord-embed-description div even though its empty. This messes with the design.

To Reproduce

  1. Create an Embed
  2. Don't add a description
  3. Add a field
  4. See the empty box above the field

Expected behavior
No div gets added when the description is empty

Screenshots
image
@favna
Copy link
Member

favna commented Dec 6, 2021

Oh that's a missing if check I guess.

@favna favna closed this as completed in f3f3302 Dec 6, 2021
@favna
Copy link
Member

favna commented Dec 6, 2021

Released in v2.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@favna @itohatweb