Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core(Settings): Use custom serializers instead of any. #334

Closed
kyranet opened this issue Oct 10, 2019 · 2 comments · Fixed by #1099
Closed

Core(Settings): Use custom serializers instead of any. #334

kyranet opened this issue Oct 10, 2019 · 2 comments · Fixed by #1099
Projects
Future v6.0.0 - Sapphire Edition
Milestone
Sapphire Migration

Comments

@kyranet
Copy link
Member

kyranet commented Oct 10, 2019

No description provided.

@kyranet kyranet added this to To do in Future via automation Oct 10, 2019
@kyranet kyranet pinned this issue Jun 19, 2020
@kyranet
Copy link
Member Author

kyranet commented Jun 19, 2020

Pinning as unconfigurable is getting removed in a near future as per dirigeants/klasa#1048.

@kyranet kyranet mentioned this issue Jun 20, 2020
Closed
13 tasks
@favna favna added this to the Klasa Core Migration milestone Jun 20, 2020
@kyranet
Copy link
Member Author

kyranet commented Jul 14, 2020

This implementation will be partial: we are missing Serializer#findIndex which is critical for the removal of entries to work.

However, implementing this is still completely doable.

@kyranet kyranet mentioned this issue Jul 16, 2020
Merged
Future automation moved this from To do to Done Jul 16, 2020
@kyranet kyranet unpinned this issue Jul 16, 2020
@kyranet kyranet added this to To do in v6.0.0 - Sapphire Edition via automation Aug 15, 2020
@kyranet kyranet moved this from To do to Done in v6.0.0 - Sapphire Edition Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Future
  
Done
v6.0.0 - Sapphire Edition
  
Done
Milestone
Sapphire Migration
Development

Successfully merging a pull request may close this issue.

feat(sg): added custom serializers skyra-project/skyra
2 participants
@favna @kyranet