Backpack Modals does not close

[NimaSoroush]

Context:
Backpack modal does not close by single click on outside modal's box. This is intermittent

Repro steps:

• go to http://backpack.prod.aws.skyscnr.com/components/web/modals/
• Open modal
• Quickly click outside of modal box

Note: Reproduced in chrome and firefox

[georgegillams]

Hi @NimaSoroush - thanks for reporting this!
This may be due to the app thinking you are dragging rather than clicking, which sometimes happens with high-precision input devices such as Wacom Bamboos. Would you mind telling us what pointing device you are using?
If this is what's happening then maybe we should update our check to discount a "drag" action if it is over a very short distance. Will have a think 😸

[NimaSoroush]

Hi @georgegillams
I can actually reproduce it on my Mac machine with chrome and firefox. I am definitely not dragging. I just quickly click outside of modal box. If I do it slowly the modal will close. My though is that some kind of asynchronous initialization happening which causes this.

[georgegillams]

Hmm.. I don't seem to be able to reproduce this in either browser on macOS. I've tried using Auto Mouse Click to perform the click in 1ms, and it works fine.

Do you mind providing more details about your system?

[georgegillams]

Also just to let you know our documentation has moved to https://backpack.github.io/components/web/modals/ and the link you provided redirects, but I can't see that making any difference

[NimaSoroush]

@georgegillams : Here is the video of reproducing it
https://screencast.com/t/c3tdsimsKgI

and system detail:

[georgegillams]

Hey @NimaSoroush - I think we may have now fixed this issue (although we haven't yet released the changes). You can test the change here https://backpack.github.io/components/web/modals/ and https://backpack.github.io/components/web/dialogs/

If you're happy with the fix, go ahead and update you dependency!
https://github.com/Skyscanner/backpack/blob/master/changelog.md#2018-02-16---fixed-mouse-clicks-not-always-closing-modals-and-dialogs

Happy to reopen this if you don't think we have resolved your issue.
Thanks again for raising this!