Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization class inverts the order of expected and actual parameters compared to other parts of the library #175

Open
janimationd opened this issue Aug 26, 2023 · 0 comments

Comments

@janimationd
Copy link

The Customization.matches(Object actual, Object expected) method inverts the order of the parameters compared to the main compare methods, e.g. JSONCompare.compareJSON(String expectedStr, String actualStr, JSONComparator comparator) and JSONAssert.assertEquals(String expectedStr, JSONObject actual, boolean strict).

Please change the code to use a consistent ordering to prevent confusion when writing custom comparison Customizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant