Changes to dependencies for cleanliness in Android

[billmag]

Not sure if you want this, but the commons-collections dependency is kind of unruly and seemed unnecessary to me. I also changed the org.json version to be the one included with Android so that there aren't version conflicts when this is used with Android.

[carterpage]

I like the idea of ditching commons-collections. Can you provide a unit test with?

We can't go backwards on the JSON library. The 2009 version is buggy as it is, and we'll probably end up cutting a support library off the latest source code to use, since @douglascrockford doesn't seem interested in releasing a new version on maven.

[carterpage]

Please undo this change. We can't go to an older JSON library. More than just android projects rely on us.

[billmag]

Would you be OK with setting a floor for the JSON version and allowing 2008, but not mandating it? If we include the 2009 version as well, Proguard does annoying things when packaging up against the Android libraries unless you explicitly exclude it from the transitive dependency list for this library.

[carterpage]

What would that be? Something like this?

<version>[20080701,)</version>

[billmag]

Something like that should probably work. I'll need to test it, which I'll
do next week if no one else does in the meantime.

On Tue, Apr 23, 2013 at 6:35 PM, Carter Page notifications@github.comwrote:

What would that be? Something like this?

[20080701,)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/30#issuecomment-16891218
.

Bill Magnuson* @billmag* :: Co-Founder & CTO ::
appboy.comhttp://www.appboy.com/
Appboy is Young Entrepreneur's startup of the
monthhttp://www.youngentrepreneur.com/startingup/start-ups/appboy-founder-on-turning-a-chance-encounter-into-entrepreneurship-gold-2/
!

[carterpage]

I've thought about it , and I'm not going to approve the maven change. Eventually we're going to release our own support version of JSON via Maven and depend on that because the artifacts have gotten so far out of date and is causing bugs in JSONAssert. Android developers, as well as anyone using needing to compile JSONAssert with an older version of JSON will need to use maven excludes.

I'd like to merge the work for getCardinalityMap, but I need two things first:

1. Write a set of thorough tests for the new functionality.
2. Undo the pom.xml change.

Follow up here if you have any questions. Thanks!