Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a MANIFEST.MF file so that the jar can be used directly in OSGi #86

Closed
wants to merge 1 commit into from

Conversation

costescuandrei
Copy link

Added a MANIFEST.MF file so that the jar (built in the usual way with maven) can be used directly in OSGi - so for example you can use it as an eclipse bundle dependency in your target platform for running junit tests.

Also added some gitignore entries to not pollute the repo. with eclipse project specific files but still be able to use it in eclipse.

maven) can be used directly in OSGi - so for example you can use it as
an eclipse bundle dependency in your target platform for running junit
tests.

Also added some gitignore entries to not pollute the repo. with eclipse
project specific files.
@carterpage
Copy link
Member

Apologies for replying 5 years late. Is this still a useful thing to have? I don't see this pattern employed in Apache repos for example.

Cannot accept as it currently is because the bundle version is hard-coded. Open to other ideas.

I did add a .gitignore to go out in the next version, partly due to your suggestion.

@carterpage carterpage closed this Jul 11, 2022
@costescuandrei
Copy link
Author

:) I still use it with those modifications.

@costescuandrei
Copy link
Author

The version is hardcoded in pom.xml as well right? So when you make a new version you can update both.

@costescuandrei
Copy link
Author

For example https://commons.apache.org/proper/commons-collections/download_collections.cgi - if you look at the jar they produce, it has a lot of osgi/manifest entries. But I think they do it via maven directly.
I see there was an effort to do this since a while back https://cwiki.apache.org/confluence/display/commons/commonsosgi - maybe there is more recent info as well (but I gtg).

@carterpage
Copy link
Member

It's a good idea, but it will need to be automated so I can guarantee consistency. I don't manually update my pom.xml, my maven release scripts do.

https://maven.apache.org/maven-release/maven-release-plugin/

If you can figure out how to make it an automatic part of the release process, without breaking the existing one, I'll merge it in. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants