Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support multiple keys in actions #13

Closed
10 tasks done
ohsayan opened this issue Aug 8, 2020 · 7 comments
Closed
10 tasks done

Feature: Support multiple keys in actions #13

ohsayan opened this issue Aug 8, 2020 · 7 comments
Assignees
@ohsayan
Labels
C-actions Related to actions C-enhancement New feature or request P-high High priority required-improvement This issue or PR addresses an already existing implementation that needs to be revised
Projects
TerrabaseDB v0.4.0
Milestone
v0.4.0

Comments

@ohsayan
Copy link
Member

ohsayan commented Aug 8, 2020 •
edited

Description
Support multiple keys in actions.

Preliminary tasks

  • Multiple SET
  • Multiple GET
  • Multiple EXIST
  • Multiple DEL
  • Multiple UPDATE
  • Upgrade existing interfaces
  • Test

Optimization

  • Refactor into kvengine
  • DB ops should return primitives
  • Use the ExceptFor type

Final tasks

  • Implement Display for ExceptFor
  • Benchmark

Also, from now on, we should be supporting multiple keys in the actions, wherever applicable.
@ohsayan ohsayan added C-enhancement New feature or request required-improvement This issue or PR addresses an already existing implementation that needs to be revised labels Aug 8, 2020
@ohsayan ohsayan added this to the v0.4.0 milestone Aug 8, 2020
@ohsayan

This comment has been minimized.

Sign in to view
@ohsayan ohsayan added the blocked This issue/PR is blocked label Aug 10, 2020
@ohsayan ohsayan pinned this issue Aug 13, 2020
@ohsayan ohsayan removed the blocked This issue/PR is blocked label Aug 16, 2020
@ohsayan

This comment has been minimized.

Sign in to view
@ohsayan
Copy link
Member Author

ohsayan commented Aug 19, 2020 •
edited

I'm seeing a negative performance impact as a result of the recent changes. I'm working on this.

Edit: Promoting this to high priority

@ohsayan ohsayan self-assigned this Aug 19, 2020
@ohsayan ohsayan added the P-high High priority label Aug 20, 2020
@ohsayan
Copy link
Member Author

ohsayan commented Aug 20, 2020 •
edited

I'm seeing a negative performance impact as a result of the recent changes. I'm working on this.

Edit: Promoting this to high priority

Looks like we're looking at another revision of the protocol. 😅

Edit: I have a draft ready

@ohsayan
Copy link
Member Author

ohsayan commented Aug 21, 2020

The parser is ready and is blazing fast. Previously we needed at least ~1μs to process the entire thing - but now: we need ~200ns to process the entire thing. That is a 500% improvement in parsing speed. Let's roger this

@ohsayan ohsayan mentioned this issue Aug 22, 2020
Closed
9 tasks
@ohsayan
Copy link
Member Author

ohsayan commented Aug 22, 2020

Now blocking on #18

@ohsayan ohsayan added the blocked This issue/PR is blocked label Aug 22, 2020
@ohsayan ohsayan added this to To do in TerrabaseDB v0.4.0 via automation Aug 22, 2020
@ohsayan ohsayan removed the blocked This issue/PR is blocked label Aug 27, 2020
@ohsayan
Copy link
Member Author

ohsayan commented Aug 27, 2020

Closing as this has been achieved

@ohsayan ohsayan closed this as completed Aug 27, 2020
TerrabaseDB v0.4.0 automation moved this from To do to Done Aug 27, 2020
@ohsayan ohsayan unpinned this issue Aug 27, 2020
@ohsayan ohsayan added the C-actions Related to actions label Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohsayan ohsayan

Labels
C-actions Related to actions C-enhancement New feature or request P-high High priority required-improvement This issue or PR addresses an already existing implementation that needs to be revised
Projects
No open projects
TerrabaseDB v0.4.0
  
Done
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@ohsayan