Upgrading clap version to 4.x for skysh

[sanjayts]

New output:

skysh 0.8.0
Sayan Nandan <ohsayan@outlook.com>
The Skytable Shell (skysh)

Usage: skysh [OPTIONS]

Options:
  -C, --sslcert <CERT>          Sets the PEM certificate to use for SSL connections
  -e, --eval [<EXPRESSION>...]  Run one or more expressions without REPL
  -h, --host <HOST>             Sets the remote host to connect to [default: 127.0.0.1]
  -p, --port <PORT>             Sets the remote port to connect to [default: 2003]
      --help                    Print help information
  -V, --version                 Print version information

old output:

Skytable Shell 0.8.0
Sayan N. <ohsayan@outlook.com>
The Skytable Shell (skysh)

USAGE:
    skysh [OPTIONS]

FLAGS:
        --help       Prints help information
    -V, --version    Prints version information

OPTIONS:
    -C, --sslcert <cert>          Sets the PEM certificate to use for SSL connections
    -e, --eval <expression>...    Run an expression without REPL
    -h, --host <host>             Sets the remote host to connect to
    -p, --port <port>             Sets the remote port to connect to

✔️ By submitting this pull request, I agree to the CLA at: https://cla.skytable.io/skytable/skytable

[glydr]

All committers have signed the CLA.

[ohsayan]

Thank you so much! Just confirming, this upgrades clap for skysh, right? In that case, could you please unlink the issue so that it's not closed when we merge this? Thanks! If you are going to add more commits, please ignore :D

[sanjayts]

You are welcome! I've removed the issue link.

And correct, this upgrades clap only for skysh. What are your thoughts on handling the changes across other compilation units? All in one PR or let us go at it one at a time? If the latter, I'll unlink the issue and then start working on skybench or something in a separate branch. WDYT?

[ohsayan]

You can do one at a time or more, whatever works/is convenient for you. skyd will require some special treatment though so I think we can leave that for another PR.

[ohsayan]

You can also consider removing the cli/src/cli.yml file since after the upgrade that will no longer be required

[ohsayan]

This is looking perfect. Let's leave this PR for skysh and do the others in separate PRs

[glydr]

@ohsayan I have dismissed your earlier review

[ohsayan]

Merged, thanks!

[ohsayan]

@sanjayts can you please add:

---
✔️  By submitting this pull request, I agree to the CLA at: https://cla.skytable.io/skytable/skytable

to the bottom of your original comment like in other pull requests? We need to keep it for compliance. Thanks!

[sanjayts]

Done @ohsayan