Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countdown Thing Improvements #240

Closed
My-Name-Is-Jeff opened this issue Jun 18, 2022 · 2 comments
Closed

Countdown Thing Improvements #240

My-Name-Is-Jeff opened this issue Jun 18, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@My-Name-Is-Jeff
Copy link
Member

Copy from Discord:

seconds keep going up
it doesn't know which second it ends so it keeps going up
https://imgur.com/8DnCAuy
Even if it has seconds:
https://imgur.com/7w1V85j

Put the text right next to the timer
like Starting in: 0d 7h 33m 35s (Monday, 01:35:00 CEST)
or just straight up 1:35:00 CEST
and orange would probably look better instead of that blue
looks out of place in skyblock menus

@My-Name-Is-Jeff My-Name-Is-Jeff added bug Something isn't working enhancement New feature or request labels Jun 18, 2022
@RayDeeUx
Copy link

wait did we release countdown calculator to public? or is this just comments from other folks testing the feature

also i don't want to make the code more spaghetti than it is, so my plan is to calculate the countdown once and not do it anymore after that. hopefully that resolves the countdown seconds going up infinitely

as for placement and color of the timestamp:
the reason i chose cyan was because it's used very rarely in sb menu item lore tooltips, making it more distinctive among a sea of lore lines. I'll probably change it to color code e which is yellow (gold is often used for highlighting coins/enchantments) as a compromise.

placing it on a new line instead of appending it to the same line as the countdown is better for readability in the long run (imagine reading a timestamp that ended on a Thursday in November. now that's a hellishly long item lore line which makes for a very very wide tooltip).

anyways that's my immediate thoughts for the time being

@RayDeeUx
Copy link

yes there's a way to grab item timestamps for auctions but that's a double edged sword hence my spaghetti code concerns

@My-Name-Is-Jeff My-Name-Is-Jeff closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants