Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC1155: Change access control for Interfece-based methods. #494

Conversation

mrklos
Copy link
Contributor

@mrklos mrklos commented Mar 21, 2022

Fix for #461

@JeneaVranceanu
Copy link
Collaborator

JeneaVranceanu commented Mar 22, 2022

@mrklos Looks good.

I thought about making protocols public but after reading some meta-questions on SO changed my view to:

We provide implementations of ERC standards and do not expect people to use protocols to implement them by themselves.

But! 🤔
As the number of protocols grows in web3 space and they are mostly built on top of some old protocol the question of making protocol IERC... public becomes more reasonable.

But it's definitely not a priority right now.

@JeneaVranceanu
Copy link
Collaborator

JeneaVranceanu commented Mar 22, 2022

@mrklos Since we provide implementation could you run through all of the ERCXYZ classes to make sure functions that are implemented as protocols requirements are marked public?

Anyway, anyone can access methods that these functions call if developers use "low-level approach" of calling functions via contract.read or contract.write. It's not something private from the smart contract perspective.

@yaroslavyaroslav yaroslavyaroslav merged commit 2e5da95 into web3swift-team:develop Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants