-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left key handler is not triggered in an empty editor #2005
Comments
@jhchen Would this be a good first bug? If so, I could give it a shot. |
I came across this too. I worked around it temporarily by binding onKeyDown in addition to the binding in the keyboard module. |
Is there any good solution for this issue? I found that this issue also occurs for the backspace key |
I came across this issue and dug into the existing default bindings for the arrow keys, eventually landing on "embed left" - https://github.com/quilljs/quill/blob/0f20a58acece17853cfec8c177543108733e722c/modules/keyboard.js#L538 This default handler returns Grabbing the name of this binding and overwriting it in my own configuration enables me to fire the event handler:
It's not a great solution as it overwrites this handler, but it works™. |
This relates to #2423. Rather than overwriting Quill's keyboard binding, you can give the keybinding a numerical name (e.g. |
Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏 |
Steps for Reproduction
right
key"right"
is printed in the consoleleft
keyExpected behavior:
"left"
is printed in the consoleActual behavior: the
left
key handler isn't calledPlatforms:
MacOS 10.13.3
Chrome 64
Version: 1.3.5
The text was updated successfully, but these errors were encountered: