Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove indentation on right-to-left line #882

Closed
benbro opened this issue Aug 23, 2016 · 1 comment
Closed

Can't remove indentation on right-to-left line #882

benbro opened this issue Aug 23, 2016 · 1 comment

Comments

@benbro
Copy link
Contributor

benbro commented Aug 23, 2016

[Describe the issue]
Followup on #874
When changing the direction of an indented line, we can't remove the indentation.

Steps for Reproduction

  1. Visit http://quilljs.com/docs/formats/
  2. Type 'abc'
  3. Click on the indent-right button.
  4. Click on the text-direction button to change to right-to-left.
  5. Try to indent right (remove indentation).

Expected behavior: [expected]
The indent left button should be highlighted.
Indenting right should remove the indentation.

Actual behavior: [actual]
The indent right button is highlighted.
Clicking on the indent right button does nothing

Platforms:
Chrome 52 on Windows 7

Version: [version]
1.0.0-rc1

@jhchen
Copy link
Member

jhchen commented Aug 26, 2016

Actually this seems like a manifestation of a larger issue with indent's active state. Like Word, it should never light up, and it is on the 1st indent level which on normal text direction this is preventing indenting past the 1st level, and on rtl is preventing dropping below 1 level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants