Large File upload causes timeout

[DestroyerAlpha]

What happened

I was experimenting different file size uploads to my slack workspace. The client timed out with a file size of about 50MB. The timeout happens after 20secs consistently.

Expected behavior

Send the file

Steps to reproduce

slackClient.UploadFile as well as slackClient.UploadFileContext with 1 minute context timeout, both fail with:

slack-go/slack2022/09/02 14:00:08 misc.go:272: HTTP/2.0 408 Request Timeout
Content-Length: 14
Content-Type: text/plain
Date: Fri, 02 Sep 2022 08:30:08 GMT
Server: envoy
Via: envoy-edge-bom-qrmq
X-Edge-Backend: envoy-www
X-Slack-Edge-Shared-Secret-Outcome: no-match

stream timeout

reproducible code

manifest.yaml

Versions

• Go: 1.18
• slack-go/slack: 0.10.2

[flowHater]

It seems to be a serverside timeout.
The default timeout for the http.Client{} is 0. which means no limit.
The python lib for Slack got the same issue: slackapi/python-slack-sdk#1165

As I can understand, they implemented an other function after exposing an other way in the Slack backend to upload File. They explained that here: https://github.com/slackapi/python-slack-sdk/releases/tag/v3.19.0

[DestroyerAlpha]

Any plans for similar support on slack-go

[sarthak-kothari]

Any plans on updating the API? Seeing similar issues

[kanata2]

@flowHater Thanks for your investigation!

[kanata2]

I'm reviewing @sarthak-kothari's PR (#1130) now.

[kanata2]

Released v0.12.0 which includes #1130.

[fr150324]

Hey @kanata2 no #1130 in https://github.com/slack-go/slack/releases/tag/v0.12.0

[kanata2]

Oh...sorry.

[flowHater]

@kanata2
Can we expect a release soon with this patch ? Or are you waiting more commits to bundle the whole in a larger release ?

[flowHater]

What I saw, is that there is still pending comments on the MR, so It's not merged and so cannot be released.

[DestroyerAlpha]

@kanata2 Would it be possible to make UploadFileV2 analogous to UploadFile. The naming of the params struct as well as the expected parameters are different (e.g. UploadFile accepted a slice of channel IDs whereas UploadFileV2 only accepts a single channel as parameter.)