Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have all the Mongo ENV variables in one place. #32

Closed
dblock opened this issue Sep 26, 2016 · 3 comments
Closed

Have all the Mongo ENV variables in one place. #32

dblock opened this issue Sep 26, 2016 · 3 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Sep 26, 2016

Extract the checking of the ENV variables into a class method and reuse it from the .yml file to avoid repeating the list. It would also let you add a variable without having to update the .yml in all downstream apps.

Related to #31.

@corprew
Copy link
Contributor

corprew commented Nov 8, 2016

@dblock before I commit a fix for this, why is the server checking all the potential mongodb variables rather than having someone set which variable to use in config? I haven't seen that, so figured I'd ask to make sure that I understood your intent.

@dblock
Copy link
Collaborator Author

dblock commented Nov 8, 2016

It's mostly to just be compatible with anything out of the box when deploying to something like Heroku. Less manual labor. If you think there's a better way, happy to hear it!

@dblock
Copy link
Collaborator Author

dblock commented Mar 7, 2017

These are now entirely in mongoid.yml, closing.

@dblock dblock closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants