Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] v1.3.0 published with invalid Gradle Module Metadata #58

Closed
3 tasks done
msfjarvis opened this issue Dec 30, 2022 · 2 comments
Closed
3 tasks done

[BUG] v1.3.0 published with invalid Gradle Module Metadata #58

msfjarvis opened this issue Dec 30, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@msfjarvis
Copy link

msfjarvis commented Dec 30, 2022

Describe the bug

The GMM for v1.3.0 contains invalid capabilities entries for the testFixtures variants so Gradle fails to resolve the dependency even if you are not relying on the test fixtures.

Capabilities in v1.2.1

Details
// curl -sL https://repo.maven.apache.org/maven2/com/slack/eithernet/eithernet/1.2.1/eithernet-1.2.1.module | jq '.variants[].capabilities? | select( . != null )'
[
  {
    "group": "com.slack.eithernet",
    "name": "eithernet-test-fixtures",
    "version": "1.2.1"
  }
]
[
  {
    "group": "com.slack.eithernet",
    "name": "eithernet-test-fixtures",
    "version": "1.2.1"
  }
]

Capabilities in v1.3.0

Details
// curl -sL https://repo.maven.apache.org/maven2/com/slack/eithernet/eithernet/1.3.0/eithernet-1.3.0.module | jq '.variants[].capabilities? | select( . != null )'
[
  {
    "group": "",
    "name": "eithernet-test-fixtures",
    "version": "unspecified"
  }
]
[
  {
    "group": "",
    "name": "eithernet-test-fixtures",
    "version": "unspecified"
  }
]
[
  {
    "group": "",
    "name": "eithernet-test-fixtures",
    "version": "unspecified"
  }
]

Build failure log

Details
* What went wrong:
Execution failed for task ':api:compileDebugKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':api:compileDebugKotlin'.
   > Could not resolve all files for configuration ':api:debugCompileClasspath'.
      > Could not resolve com.slack.eithernet:eithernet:1.3.0.
        Required by:
            project :api
         > Could not resolve com.slack.eithernet:eithernet:1.3.0.
            > Could not parse module metadata https://repo.maven.apache.org/maven2/com/slack/eithernet/eithernet/1.3.0/eithernet-1.3.0.module
               > missing 'group' at /variants[2]/capabilities[0]

Requirements

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

To Reproduce

Add the EitherNet 1.3.0 dependency to a project and attempt to build it

Expected behavior

Gradle resolves the dependency and builds the project

Reproducible in:

Project version: 1.3.0

Additional context

I noticed this in a regular Renovate PR to my app so you can repro it there but it has a rather massive dependency tree so it's probably easier to use a fresh skeleton project .

@msfjarvis msfjarvis added the bug Something isn't working label Dec 30, 2022
@ZacSweers
Copy link
Collaborator

Thanks for the report, I'll take a look soon

@ZacSweers
Copy link
Collaborator

Fixed in 1.3.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants