Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChunkInfo start time may be too early #505

Open
gjacoby126 opened this issue Mar 15, 2023 · 3 comments
Open

ChunkInfo start time may be too early #505

gjacoby126 opened this issue Mar 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@gjacoby126
Copy link
Contributor

gjacoby126 commented Mar 15, 2023

In ChunkInfo for a ReadWriteChunk, we initialize dataEndTimeEpochMs to a high sentinel value so that the first message's end time will always become the first end time, and then it can expand upward from there if any messages come in later with later timestamps.

However, we initialize dataStartTimeEpochMs to the chunk creation time, and it can then shrink earlier if any messages with earlier timestamps come in. This will lead to incorrect values if no message comes in with a timestamp earlier than or equal to the chunk creation time.

This doesn't seem to affect correctness, but it means that we may examine a chunk unnecessarily during search. Instead, the start time should be initialized to a low sentinel value so that the start time of the first message is always used.

Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 10, 2024
@bryanlb bryanlb removed the Stale label Mar 12, 2024
@bryanlb
Copy link
Contributor

bryanlb commented May 3, 2024

@allcontributors please add @gjacoby126 for bug

Copy link
Contributor

@bryanlb

I've put up a pull request to add @gjacoby126! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants